[llvm] [AMDGPU] SelectionDAG divergence tracking should take into account Target divergency. (PR #144947)

Thu Jul 3 09:54:38 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `ml-opt-dev-x86-64` running on `ml-opt-dev-x86-64-b1` while building `llvm` at step 6 "test-build-unified-tree-check-all".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/137/builds/21573

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 6 (test-build-unified-tree-check-all) failure: test (failure)
...
34.689 [46/26/698] Building CXX object unittests/CodeGen/GlobalISel/CMakeFiles/GlobalISelTests.dir/KnownBitsVectorTest.cpp.o
34.813 [45/26/699] Linking CXX executable unittests/XRay/XRayTests
34.839 [44/26/700] Building CXX object unittests/tools/llvm-cfi-verify/CMakeFiles/CFIVerifyTests.dir/GraphBuilder.cpp.o
34.858 [43/26/701] Building CXX object unittests/tools/llvm-exegesis/CMakeFiles/LLVMExegesisTests.dir/RegisterValueTest.cpp.o
34.875 [42/26/702] Building CXX object unittests/MIR/CMakeFiles/MIRTests.dir/MachineMetadata.cpp.o
34.884 [41/26/703] Linking CXX executable unittests/Transforms/Vectorize/VectorizeTests
34.886 [40/26/704] Building CXX object unittests/tools/llvm-cfi-verify/CMakeFiles/CFIVerifyTests.dir/FileAnalysis.cpp.o
34.941 [39/26/705] Building CXX object unittests/tools/llvm-exegesis/CMakeFiles/LLVMExegesisTests.dir/BenchmarkRunnerTest.cpp.o
34.954 [38/26/706] Building CXX object unittests/tools/llvm-exegesis/CMakeFiles/LLVMExegesisTests.dir/X86/BenchmarkResultTest.cpp.o
34.979 [37/26/707] Building CXX object unittests/Target/AArch64/CMakeFiles/AArch64Tests.dir/AArch64SelectionDAGTest.cpp.o
FAILED: unittests/Target/AArch64/CMakeFiles/AArch64Tests.dir/AArch64SelectionDAGTest.cpp.o 
ccache /usr/bin/c++ -DCPUINFO_SUPPORTED_PLATFORM=1 -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_STATIC -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/b/ml-opt-dev-x86-64-b1/build/unittests/Target/AArch64 -I/b/ml-opt-dev-x86-64-b1/llvm-project/llvm/unittests/Target/AArch64 -I/b/ml-opt-dev-x86-64-b1/build/include -I/b/ml-opt-dev-x86-64-b1/llvm-project/llvm/include -I/b/ml-opt-dev-x86-64-b1/llvm-project/llvm/lib/Target/AArch64 -I/b/ml-opt-dev-x86-64-b1/build/lib/Target/AArch64 -I/b/ml-opt-dev-x86-64-b1/llvm-project/third-party/unittest/googletest/include -I/b/ml-opt-dev-x86-64-b1/llvm-project/third-party/unittest/googlemock/include -isystem /tmp/tflitebuild/tensorflow/include -isystem /tmp/tflitebuild/eigen/include/eigen3 -isystem /tmp/tflitebuild/abseil-cpp/include -isystem /tmp/tflitebuild/flatbuffers/include -isystem /tmp/tflitebuild/gemmlowp/include/gemmlowp -isystem /tmp/tflitebuild/ml_dtypes/src/ml_dtypes -isystem /tmp/tflitebuild/ml_dtypes/src/ml_dtypes/ml_dtypes -isystem /tmp/tflitebuild/ruy/include -isystem /tmp/tflitebuild/cpuinfo/include -isystem /tmp/tflitebuild/ARM_NEON_2_x86_SSE/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wno-dangling-else -Wno-variadic-macros -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -DEIGEN_NEON_GEBP_NR=4 -DTFL_STATIC_LIBRARY_BUILD -Wno-suggest-override -std=c++17 -MD -MT unittests/Target/AArch64/CMakeFiles/AArch64Tests.dir/AArch64SelectionDAGTest.cpp.o -MF unittests/Target/AArch64/CMakeFiles/AArch64Tests.dir/AArch64SelectionDAGTest.cpp.o.d -o unittests/Target/AArch64/CMakeFiles/AArch64Tests.dir/AArch64SelectionDAGTest.cpp.o -c /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/unittests/Target/AArch64/AArch64SelectionDAGTest.cpp
/b/ml-opt-dev-x86-64-b1/llvm-project/llvm/unittests/Target/AArch64/AArch64SelectionDAGTest.cpp: In member function ‘virtual void llvm::AArch64SelectionDAGTest::SetUp()’:
/b/ml-opt-dev-x86-64-b1/llvm-project/llvm/unittests/Target/AArch64/AArch64SelectionDAGTest.cpp:66:22: error: no matching function for call to ‘llvm::SelectionDAG::init(llvm::MachineFunction&, llvm::OptimizationRemarkEmitter&, std::nullptr_t, std::nullptr_t, std::nullptr_t, std::nullptr_t, std::nullptr_t, llvm::MachineModuleInfo&, std::nullptr_t)’
   66 |               nullptr);
      |                      ^
In file included from /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/unittests/Target/AArch64/AArch64SelectionDAGTest.cpp:13:
/b/ml-opt-dev-x86-64-b1/llvm-project/llvm/include/llvm/CodeGen/SelectionDAG.h:472:17: note: candidate: ‘void llvm::SelectionDAG::init(llvm::MachineFunction&, llvm::OptimizationRemarkEmitter&, llvm::Pass*, const llvm::TargetLibraryInfo*, llvm::UniformityInfo*, llvm::ProfileSummaryInfo*, llvm::BlockFrequencyInfo*, llvm::MachineModuleInfo&, const llvm::FunctionVarLocs*, bool)’
  472 |   LLVM_ABI void init(MachineFunction &NewMF, OptimizationRemarkEmitter &NewORE,
      |                 ^~~~
/b/ml-opt-dev-x86-64-b1/llvm-project/llvm/include/llvm/CodeGen/SelectionDAG.h:472:17: note:   candidate expects 10 arguments, 9 provided
/b/ml-opt-dev-x86-64-b1/llvm-project/llvm/include/llvm/CodeGen/SelectionDAG.h:478:8: note: candidate: ‘void llvm::SelectionDAG::init(llvm::MachineFunction&, llvm::OptimizationRemarkEmitter&, llvm::MachineFunctionAnalysisManager&, const llvm::TargetLibraryInfo*, llvm::UniformityInfo*, llvm::ProfileSummaryInfo*, llvm::BlockFrequencyInfo*, llvm::MachineModuleInfo&, const llvm::FunctionVarLocs*, bool)’
  478 |   void init(MachineFunction &NewMF, OptimizationRemarkEmitter &NewORE,
      |        ^~~~
/b/ml-opt-dev-x86-64-b1/llvm-project/llvm/include/llvm/CodeGen/SelectionDAG.h:478:8: note:   candidate expects 10 arguments, 9 provided
34.997 [37/25/708] Building CXX object unittests/tools/llvm-exegesis/CMakeFiles/LLVMExegesisTests.dir/ProgressMeterTest.cpp.o
35.002 [37/24/709] Building CXX object unittests/tools/llvm-exegesis/CMakeFiles/LLVMExegesisTests.dir/ClusteringTest.cpp.o
35.178 [37/23/710] Linking CXX executable unittests/Transforms/Vectorize/SandboxVectorizer/SandboxVectorizerTests
36.120 [37/22/711] Linking CXX executable unittests/Transforms/Scalar/ScalarTests
36.451 [37/21/712] Linking CXX executable unittests/Transforms/Utils/UtilsTests
37.631 [37/20/713] Building CXX object unittests/Target/AArch64/CMakeFiles/AArch64Tests.dir/AddressingModes.cpp.o
39.500 [37/19/714] Building CXX object unittests/Target/VE/CMakeFiles/VETests.dir/MachineInstrTest.cpp.o
39.553 [37/18/715] Building CXX object unittests/Target/AArch64/CMakeFiles/AArch64Tests.dir/MatrixRegisterAliasing.cpp.o
39.670 [37/17/716] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/InstrRefLDVTest.cpp.o
In file included from /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/include/llvm/ADT/ArrayRef.h:13,
                 from /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/include/llvm/IR/DataLayout.h:23,
                 from /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/include/llvm/Target/TargetMachine.h:17,
                 from /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/include/llvm/CodeGen/CodeGenTargetMachineImpl.h:16,
                 from /b/ml-opt-dev-x86-64-b1/llvm-project/llvm/unittests/CodeGen/InstrRefLDVTest.cpp:9:
/b/ml-opt-dev-x86-64-b1/llvm-project/llvm/include/llvm/ADT/SmallVector.h: In member function ‘virtual void InstrRefLDVTest_VLocDiamondBlocks_Test::TestBody()’:
/b/ml-opt-dev-x86-64-b1/llvm-project/llvm/include/llvm/ADT/SmallVector.h:647:24: warning: array subscript 215 is outside array bounds of ‘llvm::SmallVector<LiveDebugValues::VLocTracker, 1> [1]’ [-Warray-bounds]
  647 |     this->destroy_range(this->begin() + N, this->end());
      |     ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/b/ml-opt-dev-x86-64-b1/llvm-project/llvm/unittests/CodeGen/InstrRefLDVTest.cpp:2714:31: note: while referencing ‘VLocs’
 2714 |   SmallVector<VLocTracker, 1> VLocs;
      |                               ^~~~~
39.736 [37/16/717] Building CXX object unittests/Target/LoongArch/CMakeFiles/LoongArchTests.dir/InstSizes.cpp.o
39.747 [37/15/718] Building CXX object unittests/Target/AArch64/CMakeFiles/AArch64Tests.dir/AArch64RegisterInfoTest.cpp.o
39.919 [37/14/719] Building CXX object unittests/Target/AArch64/CMakeFiles/AArch64Tests.dir/Immediates.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/144947