[llvm] 51ff8f2 - [X86] foldXor1SetCC - pull out repeated SDLoc. NFC.

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 3 08:03:25 PDT 2025


Author: Simon Pilgrim
Date: 2025-07-03T16:03:13+01:00
New Revision: 51ff8f2f7e4c997170be8f3b29f8bdd37d4a2a78

URL: https://github.com/llvm/llvm-project/commit/51ff8f2f7e4c997170be8f3b29f8bdd37d4a2a78
DIFF: https://github.com/llvm/llvm-project/commit/51ff8f2f7e4c997170be8f3b29f8bdd37d4a2a78.diff

LOG: [X86] foldXor1SetCC - pull out repeated SDLoc. NFC.

Added: 
    

Modified: 
    llvm/lib/Target/X86/X86ISelLowering.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp
index 136d398359afd..b85c3e3d94ad8 100644
--- a/llvm/lib/Target/X86/X86ISelLowering.cpp
+++ b/llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -54822,9 +54822,8 @@ static SDValue lowerX86FPLogicOp(SDNode *N, SelectionDAG &DAG,
   return DAG.getBitcast(VT, IntOp);
 }
 
-
 /// Fold a xor(setcc cond, val), 1 --> setcc (inverted(cond), val)
-static SDValue foldXor1SetCC(SDNode *N, SelectionDAG &DAG) {
+static SDValue foldXor1SetCC(SDNode *N, const SDLoc &DL, SelectionDAG &DAG) {
   if (N->getOpcode() != ISD::XOR)
     return SDValue();
 
@@ -54834,7 +54833,6 @@ static SDValue foldXor1SetCC(SDNode *N, SelectionDAG &DAG) {
 
   X86::CondCode NewCC = X86::GetOppositeBranchCondition(
       X86::CondCode(LHS->getConstantOperandVal(0)));
-  SDLoc DL(N);
   return getSETCC(NewCC, LHS->getOperand(1), DL, DAG);
 }
 
@@ -54932,7 +54930,7 @@ static SDValue combineXor(SDNode *N, SelectionDAG &DAG,
   if (DCI.isBeforeLegalizeOps())
     return SDValue();
 
-  if (SDValue SetCC = foldXor1SetCC(N, DAG))
+  if (SDValue SetCC = foldXor1SetCC(N, DL, DAG))
     return SetCC;
 
   if (SDValue R = combineOrXorWithSETCC(N->getOpcode(), DL, VT, N0, N1, DAG))


        


More information about the llvm-commits mailing list