[llvm] [llvm][SandBoxIR] Fix Windows+clang compiler warning (PR #146905)

David Spickett via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 3 07:27:37 PDT 2025


https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/146905

C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\llvm\include\llvm/SandboxIR/Value.h(172,16): warning: unqualified friend declaration referring to type outside of the nearest enclosing namespace is a Microsoft extension; add a nested name specifier [-Wmicrosoft-unqualified-friend]

Clang suggests adding ::llvm::, but:
* Region is in ::llvm::sandboxir
* Region is not defined at this point

So forward declare it.

>From 09ca36b139904f06af653ae17d0f1b39635282ab Mon Sep 17 00:00:00 2001
From: David Spickett <david.spickett at linaro.org>
Date: Thu, 3 Jul 2025 14:25:57 +0000
Subject: [PATCH] [llvm][SandBoxIR] Fix Windows+clang compiler warning

C:\Users\tcwg\llvm-worker\lldb-aarch64-windows\llvm-project\llvm\include\llvm/SandboxIR/Value.h(172,16): warning: unqualified friend declaration referring to type outside of the nearest enclosing namespace is a Microsoft extension; add a nested name specifier [-Wmicrosoft-unqualified-friend]

Clang suggests adding ::llvm::, but:
* Region is in ::llvm::sandboxir
* Region is not defined at this point

So forward declare it.
---
 llvm/include/llvm/SandboxIR/Value.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/llvm/include/llvm/SandboxIR/Value.h b/llvm/include/llvm/SandboxIR/Value.h
index dd0bc76db3e37..8e50614d6a6d0 100644
--- a/llvm/include/llvm/SandboxIR/Value.h
+++ b/llvm/include/llvm/SandboxIR/Value.h
@@ -33,6 +33,7 @@ class IntrinsicInst;
 class Operator;
 class OverflowingBinaryOperator;
 class FPMathOperator;
+class Region;
 
 /// Iterator for the `Use` edges of a Value's users.
 /// \Returns a `Use` when dereferenced.



More information about the llvm-commits mailing list