[lldb] [llvm] [lldb][NFC][MachO] Clean up LC_THREAD reading code, remove i386 corefile (PR #146480)

Wed Jul 2 13:04:06 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `publish-sphinx-docs` running on `as-worker-4` while building `lldb,llvm` at step 5 "build-docs-llvm-html-docs-clang-html-docs-clang...".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/45/builds/13922

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (build-docs-llvm-html-docs-clang-html-docs-clang...) failure: build (failure)
...
1580.272 [638/24/4825] Building CXX object tools/lldb/source/Plugins/ObjectFile/COFF/CMakeFiles/lldbPluginObjectFileCOFF.dir/ObjectFileCOFF.cpp.o
1580.644 [637/24/4826] Building CXX object tools/lldb/source/Plugins/ObjectFile/PECOFF/CMakeFiles/lldbPluginObjectFilePECOFF.dir/PECallFrameInfo.cpp.o
1581.540 [636/24/4827] Building CXX object tools/lldb/source/Plugins/ObjectFile/PDB/CMakeFiles/lldbPluginObjectFilePDB.dir/ObjectFilePDB.cpp.o
1581.837 [635/24/4828] Building CXX object tools/lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/CMakeFiles/lldbPluginAppleObjCRuntime.dir/AppleObjCTypeEncodingParser.cpp.o
1581.961 [634/24/4829] Building CXX object tools/lldb/source/Plugins/ObjectFile/Minidump/CMakeFiles/lldbPluginObjectFileMinidump.dir/ObjectFileMinidump.cpp.o
1582.242 [633/24/4830] Building CXX object tools/lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/CMakeFiles/lldbPluginAppleObjCRuntime.dir/AppleObjCTrampolineHandler.cpp.o
1582.311 [632/24/4831] Building CXX object tools/lldb/source/Plugins/LanguageRuntime/ObjC/GNUstepObjCRuntime/CMakeFiles/lldbPluginGNUstepObjCRuntime.dir/GNUstepObjCRuntime.cpp.o
1582.921 [631/24/4832] Building CXX object tools/lldb/source/Plugins/ObjectFile/PECOFF/CMakeFiles/lldbPluginObjectFilePECOFF.dir/WindowsMiniDump.cpp.o
1583.073 [630/24/4833] Building CXX object tools/lldb/source/Plugins/Platform/Android/CMakeFiles/lldbPluginPlatformAndroid.dir/AdbClient.cpp.o
1583.308 [629/24/4834] Building CXX object tools/lldb/source/Plugins/ObjectFile/Mach-O/CMakeFiles/lldbPluginObjectFileMachO.dir/ObjectFileMachO.cpp.o
FAILED: tools/lldb/source/Plugins/ObjectFile/Mach-O/CMakeFiles/lldbPluginObjectFileMachO.dir/ObjectFileMachO.cpp.o 
/usr/bin/c++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbot/as-worker-4/publish-sphinx-docs/build/tools/lldb/source/Plugins/ObjectFile/Mach-O -I/home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/lldb/source/Plugins/ObjectFile/Mach-O -I/home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/lldb/include -I/home/buildbot/as-worker-4/publish-sphinx-docs/build/tools/lldb/include -I/home/buildbot/as-worker-4/publish-sphinx-docs/build/include -I/home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/llvm/include -I/usr/include/python3.8 -I/home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/llvm/../clang/include -I/home/buildbot/as-worker-4/publish-sphinx-docs/build/tools/lldb/../clang/include -I/home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/lldb/source -I/home/buildbot/as-worker-4/publish-sphinx-docs/build/tools/lldb/source -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -Wno-unknown-pragmas -Wno-strict-aliasing -Wno-stringop-truncation -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -std=c++17 -MD -MT tools/lldb/source/Plugins/ObjectFile/Mach-O/CMakeFiles/lldbPluginObjectFileMachO.dir/ObjectFileMachO.cpp.o -MF tools/lldb/source/Plugins/ObjectFile/Mach-O/CMakeFiles/lldbPluginObjectFileMachO.dir/ObjectFileMachO.cpp.o.d -o tools/lldb/source/Plugins/ObjectFile/Mach-O/CMakeFiles/lldbPluginObjectFileMachO.dir/ObjectFileMachO.cpp.o -c /home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
/home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp: In member function ‘void RegisterContextDarwin_arm_Mach::SetRegisterDataFrom_LC_THREAD(const lldb_private::DataExtractor&)’:
/home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:415:7: error: expected primary-expression before ‘}’ token
  415 |       }
      |       ^
/home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp: In member function ‘void RegisterContextDarwin_arm64_Mach::SetRegisterDataFrom_LC_THREAD(const lldb_private::DataExtractor&)’:
/home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:536:7: error: expected primary-expression before ‘}’ token
  536 |       }
      |       ^
/home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp: In member function ‘void RegisterContextDarwin_riscv32_Mach::SetRegisterDataFrom_LC_THREAD(const lldb_private::DataExtractor&)’:
/home/buildbot/as-worker-4/publish-sphinx-docs/llvm-project/lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:672:7: error: expected primary-expression before ‘}’ token
  672 |       }
      |       ^
1583.881 [629/23/4835] Building CXX object tools/lldb/source/Plugins/ObjectFile/Placeholder/CMakeFiles/lldbPluginObjectFilePlaceholder.dir/ObjectFilePlaceholder.cpp.o
1585.129 [629/22/4836] Building CXX object tools/lldb/source/Plugins/ObjectFile/Minidump/CMakeFiles/lldbPluginObjectFileMinidump.dir/MinidumpFileBuilder.cpp.o
1585.706 [629/21/4837] Building CXX object tools/lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/CMakeFiles/lldbPluginAppleObjCRuntime.dir/AppleObjCRuntimeV2.cpp.o
1586.261 [629/20/4838] Building CXX object tools/lldb/source/Plugins/ObjectFile/wasm/CMakeFiles/lldbPluginObjectFileWasm.dir/ObjectFileWasm.cpp.o
1586.482 [629/19/4839] Building CXX object tools/lldb/source/Plugins/ObjectFile/XCOFF/CMakeFiles/lldbPluginObjectFileXCOFF.dir/ObjectFileXCOFF.cpp.o
1586.916 [629/18/4840] Building CXX object tools/lldb/source/Plugins/ObjectFile/PECOFF/CMakeFiles/lldbPluginObjectFilePECOFF.dir/ObjectFilePECOFF.cpp.o
1587.321 [629/17/4841] Building CXX object tools/lldb/source/Plugins/Platform/Android/CMakeFiles/lldbPluginPlatformAndroid.dir/PlatformAndroidRemoteGDBServer.cpp.o
1588.278 [629/16/4842] Building CXX object tools/lldb/source/Plugins/OperatingSystem/Python/CMakeFiles/lldbPluginOperatingSystemPython.dir/OperatingSystemPython.cpp.o
1588.845 [629/15/4843] Building CXX object tools/lldb/source/Plugins/ObjectFile/ELF/CMakeFiles/lldbPluginObjectFileELF.dir/ObjectFileELF.cpp.o
1589.600 [629/14/4844] Building CXX object tools/lldb/source/Plugins/Platform/MacOSX/CMakeFiles/lldbPluginPlatformMacOSX.dir/PlatformDarwinKernel.cpp.o
1590.572 [629/13/4845] Building CXX object tools/lldb/source/Plugins/Platform/MacOSX/CMakeFiles/lldbPluginPlatformMacOSX.dir/PlatformDarwinDevice.cpp.o
1590.972 [629/12/4846] Building CXX object tools/lldb/source/Plugins/Platform/MacOSX/CMakeFiles/lldbPluginPlatformMacOSX.dir/PlatformRemoteAppleBridge.cpp.o
1591.101 [629/11/4847] Building CXX object tools/lldb/source/Plugins/Platform/gdb-server/CMakeFiles/lldbPluginPlatformGDB.dir/PlatformRemoteGDBServer.cpp.o
1591.184 [629/10/4848] Building CXX object tools/lldb/source/Plugins/Platform/MacOSX/CMakeFiles/lldbPluginPlatformMacOSX.dir/PlatformRemoteAppleWatch.cpp.o
1591.219 [629/9/4849] Building CXX object tools/lldb/source/Plugins/Platform/MacOSX/CMakeFiles/lldbPluginPlatformMacOSX.dir/PlatformMacOSX.cpp.o
1591.367 [629/8/4850] Building CXX object tools/lldb/source/Plugins/Platform/MacOSX/CMakeFiles/lldbPluginPlatformMacOSX.dir/PlatformRemoteAppleTV.cpp.o
1591.821 [629/7/4851] Building CXX object tools/lldb/source/Plugins/Platform/MacOSX/CMakeFiles/lldbPluginPlatformMacOSX.dir/PlatformRemoteAppleXR.cpp.o
1593.034 [629/6/4852] Building CXX object tools/lldb/source/Plugins/Platform/AIX/CMakeFiles/lldbPluginPlatformAIX.dir/PlatformAIX.cpp.o
1594.628 [629/5/4853] Building CXX object tools/lldb/source/Plugins/Platform/FreeBSD/CMakeFiles/lldbPluginPlatformFreeBSD.dir/PlatformFreeBSD.cpp.o
1594.747 [629/4/4854] Building CXX object tools/lldb/source/Plugins/Platform/Android/CMakeFiles/lldbPluginPlatformAndroid.dir/PlatformAndroid.cpp.o
1596.032 [629/3/4855] Building CXX object tools/lldb/source/Plugins/Platform/Linux/CMakeFiles/lldbPluginPlatformLinux.dir/PlatformLinux.cpp.o
1600.123 [629/2/4856] Building CXX object tools/lldb/source/Plugins/Platform/MacOSX/CMakeFiles/lldbPluginPlatformMacOSX.dir/PlatformDarwin.cpp.o
1604.356 [629/1/4857] Building CXX object tools/lldb/source/Plugins/Instruction/RISCV/CMakeFiles/lldbPluginInstructionRISCV.dir/EmulateInstructionRISCV.cpp.o
ninja: build stopped: subcommand failed.

```

</details>

https://github.com/llvm/llvm-project/pull/146480