[llvm] 8eb61d9 - [SHT_LLVM_BB_ADDR_MAP] Cleanup old version support code from ELF.cpp.

via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 2 13:01:47 PDT 2025


Author: Rahman Lavaee
Date: 2025-07-02T13:01:43-07:00
New Revision: 8eb61d9154c5379c1a74f65aa850cac5060c8b0a

URL: https://github.com/llvm/llvm-project/commit/8eb61d9154c5379c1a74f65aa850cac5060c8b0a
DIFF: https://github.com/llvm/llvm-project/commit/8eb61d9154c5379c1a74f65aa850cac5060c8b0a.diff

LOG: [SHT_LLVM_BB_ADDR_MAP] Cleanup old version support code from ELF.cpp.

This change was mistakenly dropped from the prior commit 6b623a6622707ea47d84ab0069f766215a6fec44

Added: 
    

Modified: 
    llvm/lib/Object/ELF.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Object/ELF.cpp b/llvm/lib/Object/ELF.cpp
index 1d9fd6b445e17..8a6efc46212c1 100644
--- a/llvm/lib/Object/ELF.cpp
+++ b/llvm/lib/Object/ELF.cpp
@@ -885,9 +885,7 @@ decodeBBAddrMapImpl(const ELFFile<ELFT> &EF,
         for (uint32_t BlockIndex = 0; !MetadataDecodeErr && !ULEBSizeErr &&
                                       Cur && (BlockIndex < NumBlocksInBBRange);
              ++BlockIndex) {
-          uint32_t ID = Version >= 2
-                            ? readULEB128As<uint32_t>(Data, Cur, ULEBSizeErr)
-                            : BlockIndex;
+          uint32_t ID = readULEB128As<uint32_t>(Data, Cur, ULEBSizeErr);
           uint32_t Offset = readULEB128As<uint32_t>(Data, Cur, ULEBSizeErr);
           // Read the callsite offsets.
           uint32_t LastCallsiteOffset = 0;
@@ -907,11 +905,6 @@ decodeBBAddrMapImpl(const ELFFile<ELFT> &EF,
           uint32_t Size = readULEB128As<uint32_t>(Data, Cur, ULEBSizeErr) +
                           LastCallsiteOffset;
           uint32_t MD = readULEB128As<uint32_t>(Data, Cur, ULEBSizeErr);
-          if (Version >= 1) {
-            // Offset is calculated relative to the end of the previous BB.
-            Offset += PrevBBEndOffset;
-            PrevBBEndOffset = Offset + Size;
-          }
           Expected<BBAddrMap::BBEntry::Metadata> MetadataOrErr =
               BBAddrMap::BBEntry::Metadata::decode(MD);
           if (!MetadataOrErr) {
@@ -919,7 +912,8 @@ decodeBBAddrMapImpl(const ELFFile<ELFT> &EF,
             break;
           }
           BBEntries.push_back(
-              {ID, Offset, Size, *MetadataOrErr, CallsiteOffsets});
+              {ID, Offset + PrevBBEndOffset, Size, *MetadataOrErr, CallsiteOffsets});
+          PrevBBEndOffset += Offset + Size;
         }
         TotalNumBlocks += BBEntries.size();
       }


        


More information about the llvm-commits mailing list