[llvm] [AsmParser] Remove unnecessary casts (NFC) (PR #146549)

[Kazu Hirata via llvm-commits]

https://github.com/kazutakahirata updated https://github.com/llvm/llvm-project/pull/146549

>From 3e4fb96889ffedb0e0f4ccef62ab7e38ee86bdb6 Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Tue, 1 Jul 2025 07:41:20 -0700
Subject: [PATCH 1/2] [AsmParser] Remove unnecessary casts (NFC)

Linkage is already of GlobalValue::LinkageTypes.
---
 llvm/lib/AsmParser/LLParser.cpp | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/llvm/lib/AsmParser/LLParser.cpp b/llvm/lib/AsmParser/LLParser.cpp
index 7e488b96764a5..bb41f53601f91 100644
--- a/llvm/lib/AsmParser/LLParser.cpp
+++ b/llvm/lib/AsmParser/LLParser.cpp
@@ -1234,14 +1234,12 @@ bool LLParser::parseAliasOrIFunc(const std::string &Name, unsigned NameID,
   std::unique_ptr<GlobalIFunc> GI;
   GlobalValue *GV;
   if (IsAlias) {
-    GA.reset(GlobalAlias::create(Ty, AddrSpace,
-                                 (GlobalValue::LinkageTypes)Linkage, Name,
-                                 Aliasee, /*Parent*/ nullptr));
+    GA.reset(GlobalAlias::create(Ty, AddrSpace, Linkage, Name, Aliasee,
+                                 /*Parent*/ nullptr));
     GV = GA.get();
   } else {
-    GI.reset(GlobalIFunc::create(Ty, AddrSpace,
-                                 (GlobalValue::LinkageTypes)Linkage, Name,
-                                 Aliasee, /*Parent*/ nullptr));
+    GI.reset(GlobalIFunc::create(Ty, AddrSpace, Linkage, Name, Aliasee,
+                                 /*Parent*/ nullptr));
     GV = GI.get();
   }
   GV->setThreadLocalMode(TLM);

>From b400c3ca9e4ac706e8b4cdcd47b5dbfda507b122 Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Tue, 1 Jul 2025 11:20:26 -0700
Subject: [PATCH 2/2] Address a comment.

---
 llvm/lib/AsmParser/LLParser.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/llvm/lib/AsmParser/LLParser.cpp b/llvm/lib/AsmParser/LLParser.cpp
index bb41f53601f91..145b90337dbf9 100644
--- a/llvm/lib/AsmParser/LLParser.cpp
+++ b/llvm/lib/AsmParser/LLParser.cpp
@@ -1235,11 +1235,11 @@ bool LLParser::parseAliasOrIFunc(const std::string &Name, unsigned NameID,
   GlobalValue *GV;
   if (IsAlias) {
     GA.reset(GlobalAlias::create(Ty, AddrSpace, Linkage, Name, Aliasee,
-                                 /*Parent*/ nullptr));
+                                 /*Parent*/nullptr));
     GV = GA.get();
   } else {
     GI.reset(GlobalIFunc::create(Ty, AddrSpace, Linkage, Name, Aliasee,
-                                 /*Parent*/ nullptr));
+                                 /*Parent*/nullptr));
     GV = GI.get();
   }
   GV->setThreadLocalMode(TLM);