[llvm] test fix (PR #146459)

S. VenkataKeerthy via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 30 20:24:38 PDT 2025


https://github.com/svkeerthy created https://github.com/llvm/llvm-project/pull/146459

None

>From 783686328ce8b710ffad85dafc73371d5dcffb2c Mon Sep 17 00:00:00 2001
From: svkeerthy <venkatakeerthy at google.com>
Date: Tue, 1 Jul 2025 03:24:07 +0000
Subject: [PATCH] test fix

---
 llvm/lib/Analysis/IR2Vec.cpp           | 1 -
 llvm/unittests/Analysis/IR2VecTest.cpp | 9 +--------
 2 files changed, 1 insertion(+), 9 deletions(-)

diff --git a/llvm/lib/Analysis/IR2Vec.cpp b/llvm/lib/Analysis/IR2Vec.cpp
index 47ad2fa139c49..895b3de58a54e 100644
--- a/llvm/lib/Analysis/IR2Vec.cpp
+++ b/llvm/lib/Analysis/IR2Vec.cpp
@@ -129,7 +129,6 @@ std::unique_ptr<Embedder> Embedder::create(IR2VecKind Mode, const Function &F,
   case IR2VecKind::Symbolic:
     return std::make_unique<SymbolicEmbedder>(F, Vocabulary);
   }
-  llvm_unreachable("Unknown IR2Vec kind");
   return nullptr;
 }
 
diff --git a/llvm/unittests/Analysis/IR2VecTest.cpp b/llvm/unittests/Analysis/IR2VecTest.cpp
index 05af55b59323b..ba0e4e2825ec1 100644
--- a/llvm/unittests/Analysis/IR2VecTest.cpp
+++ b/llvm/unittests/Analysis/IR2VecTest.cpp
@@ -228,16 +228,9 @@ TEST(IR2VecTest, CreateInvalidMode) {
   FunctionType *FTy = FunctionType::get(Type::getVoidTy(Ctx), false);
   Function *F = Function::Create(FTy, Function::ExternalLinkage, "f", M);
 
-// static_cast an invalid int to IR2VecKind
-#ifndef NDEBUG
-#if GTEST_HAS_DEATH_TEST
-  EXPECT_DEATH(Embedder::create(static_cast<IR2VecKind>(-1), *F, V),
-               "Unknown IR2Vec kind");
-#endif // GTEST_HAS_DEATH_TEST
-#else
+  // static_cast an invalid int to IR2VecKind
   auto Result = Embedder::create(static_cast<IR2VecKind>(-1), *F, V);
   EXPECT_FALSE(static_cast<bool>(Result));
-#endif // NDEBUG
 }
 
 TEST(IR2VecTest, LookupVocab) {



More information about the llvm-commits mailing list