[llvm] [AArch64] Enable other cost kinds for getCmpSelInstrCost. (PR #144375)
Hassnaa Hamdi via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 30 07:58:27 PDT 2025
================
@@ -4264,11 +4264,6 @@ InstructionCost AArch64TTIImpl::getCmpSelInstrCost(
unsigned Opcode, Type *ValTy, Type *CondTy, CmpInst::Predicate VecPred,
TTI::TargetCostKind CostKind, TTI::OperandValueInfo Op1Info,
TTI::OperandValueInfo Op2Info, const Instruction *I) const {
- // TODO: Handle other cost kinds.
- if (CostKind != TTI::TCK_RecipThroughput)
----------------
hassnaaHamdi wrote:
Okay, thanks for clarification.
Could you add a TODO for the cases in this function that still don't consider the costkind and they still cause wrong costs, like this case: `if (isa<FixedVectorType>(ValTy) && ISD == ISD::SELECT)`?
https://github.com/llvm/llvm-project/pull/144375
More information about the llvm-commits
mailing list