[llvm] [SLP] Avoid -passes=instcombine stages in SLP tests (PR #146257)

[via llvm-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {undef deprecator}-->


:warning: undef deprecator found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git diff -U0 --pickaxe-regex -S '([^a-zA-Z0-9#_-]undef[^a-zA-Z0-9_-]|UndefValue::get)' 'HEAD~1' HEAD llvm/test/Transforms/SLPVectorizer/AArch64/gather-cost.ll llvm/test/Transforms/SLPVectorizer/AArch64/gather-reduce.ll llvm/test/Transforms/SLPVectorizer/AArch64/getelementptr.ll llvm/test/Transforms/SLPVectorizer/AArch64/getelementptr2.ll llvm/test/Transforms/SLPVectorizer/AArch64/loadorder.ll llvm/test/Transforms/SLPVectorizer/AArch64/transpose-inseltpoison.ll llvm/test/Transforms/SLPVectorizer/AArch64/transpose.ll llvm/test/Transforms/SLPVectorizer/AMDGPU/add_sub_sat-inseltpoison.ll llvm/test/Transforms/SLPVectorizer/AMDGPU/add_sub_sat.ll llvm/test/Transforms/SLPVectorizer/AMDGPU/min_max.ll llvm/test/Transforms/SLPVectorizer/WebAssembly/no-vectorize-rotate.ll llvm/test/Transforms/SLPVectorizer/X86/alternate-calls-inseltpoison.ll llvm/test/Transforms/SLPVectorizer/X86/alternate-calls.ll llvm/test/Transforms/SLPVectorizer/X86/alternate-cast-inseltpoison.ll llvm/test/Transforms/SLPVectorizer/X86/alternate-cast.ll llvm/test/Transforms/SLPVectorizer/X86/alternate-fp-inseltpoison.ll llvm/test/Transforms/SLPVectorizer/X86/alternate-fp.ll llvm/test/Transforms/SLPVectorizer/X86/alternate-int-inseltpoison.ll llvm/test/Transforms/SLPVectorizer/X86/alternate-int.ll llvm/test/Transforms/SLPVectorizer/X86/blending-shuffle-inseltpoison.ll llvm/test/Transforms/SLPVectorizer/X86/blending-shuffle.ll llvm/test/Transforms/SLPVectorizer/X86/cmp_commute-inseltpoison.ll llvm/test/Transforms/SLPVectorizer/X86/cmp_commute.ll llvm/test/Transforms/SLPVectorizer/X86/hadd-inseltpoison.ll llvm/test/Transforms/SLPVectorizer/X86/hadd.ll llvm/test/Transforms/SLPVectorizer/X86/hsub-inseltpoison.ll llvm/test/Transforms/SLPVectorizer/X86/hsub.ll llvm/test/Transforms/SLPVectorizer/X86/minimum-sizes.ll llvm/test/Transforms/SLPVectorizer/X86/operandorder.ll llvm/test/Transforms/SLPVectorizer/X86/pr40522.ll llvm/test/Transforms/SLPVectorizer/X86/pr46983.ll llvm/test/Transforms/SLPVectorizer/X86/pr47623.ll llvm/test/Transforms/SLPVectorizer/X86/pr47629-inseltpoison.ll llvm/test/Transforms/SLPVectorizer/X86/pr47629.ll llvm/test/Transforms/SLPVectorizer/X86/pr47642.ll llvm/test/Transforms/SLPVectorizer/X86/pr49081.ll llvm/test/Transforms/SLPVectorizer/X86/reverse_extract_elements.ll llvm/test/Transforms/SLPVectorizer/revec-shufflevector.ll
``````````

</details>


The following files introduce new uses of undef:
 - llvm/test/Transforms/SLPVectorizer/AMDGPU/add_sub_sat.ll
 - llvm/test/Transforms/SLPVectorizer/AMDGPU/min_max.ll
 - llvm/test/Transforms/SLPVectorizer/X86/pr47629.ll
 - llvm/test/Transforms/SLPVectorizer/X86/pr47642.ll

[Undef](https://llvm.org/docs/LangRef.html#undefined-values) is now deprecated and should only be used in the rare cases where no replacement is possible. For example, a load of uninitialized memory yields `undef`. You should use `poison` values for placeholders instead.

In tests, avoid using `undef` and having tests that trigger undefined behavior. If you need an operand with some unimportant value, you can add a new argument to the function and use that instead.

For example, this is considered a bad practice:
```llvm
define void @fn() {
  ...
  br i1 undef, ...
}
```

Please use the following instead:
```llvm
define void @fn(i1 %cond) {
  ...
  br i1 %cond, ...
}
```

Please refer to the [Undefined Behavior Manual](https://llvm.org/docs/UndefinedBehavior.html) for more information.



https://github.com/llvm/llvm-project/pull/146257