[llvm] DRAFT: remove llvm-bolt-wrapper logic from nfc setup (PR #146209)
Paschalis Mpeis via llvm-commits
llvm-commits at lists.llvm.org
Sat Jun 28 05:35:56 PDT 2025
https://github.com/paschalis-mpeis created https://github.com/llvm/llvm-project/pull/146209
None
>From ccdabc59f77204827a0a280e0d1651d32eea4e8f Mon Sep 17 00:00:00 2001
From: Paschalis Mpeis <Paschalis.Mpeis at arm.com>
Date: Sat, 28 Jun 2025 13:23:16 +0100
Subject: [PATCH] DRAFT: remove llvm-bolt-wrapper logic from nfc setup
---
bolt/utils/nfc-check-setup.py | 15 ++-------------
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/bolt/utils/nfc-check-setup.py b/bolt/utils/nfc-check-setup.py
index 275ac7b886d00..9e4fc8bc101b1 100755
--- a/bolt/utils/nfc-check-setup.py
+++ b/bolt/utils/nfc-check-setup.py
@@ -48,8 +48,7 @@ def main():
description=textwrap.dedent(
"""
This script builds two versions of BOLT (with the current and
- previous revision) and sets up symlink for llvm-bolt-wrapper.
- Passes the options through to llvm-bolt-wrapper.
+ previous revision).
"""
)
)
@@ -76,7 +75,7 @@ def main():
default="HEAD^",
help="Revision to checkout to compare vs HEAD",
)
- args, wrapper_args = parser.parse_known_args()
+ args = parser.parse_args()
bolt_path = f"{args.build_dir}/bin/llvm-bolt"
source_dir = None
@@ -90,7 +89,6 @@ def main():
sys.exit("Source directory is not found")
script_dir = os.path.dirname(os.path.abspath(__file__))
- wrapper_path = f"{script_dir}/llvm-bolt-wrapper.py"
# build the current commit
subprocess.run(
shlex.split("cmake --build . --target llvm-bolt"), cwd=args.build_dir
@@ -131,15 +129,6 @@ def main():
)
# rename llvm-bolt
os.replace(bolt_path, f"{bolt_path}.old")
- # set up llvm-bolt-wrapper.ini
- ini = subprocess.check_output(
- shlex.split(f"{wrapper_path} {bolt_path}.old {bolt_path}.new") + wrapper_args,
- text=True,
- )
- with open(f"{args.build_dir}/bin/llvm-bolt-wrapper.ini", "w") as f:
- f.write(ini)
- # symlink llvm-bolt-wrapper
- os.symlink(wrapper_path, bolt_path)
if args.switch_back:
if stash:
subprocess.run(shlex.split("git stash pop"), cwd=source_dir)
More information about the llvm-commits
mailing list