[llvm] Revert "[llvm][EmbedBitcodePass] Prevent modifying the module with ThinLTO" (PR #145987)

[LLVM Continuous Integration via llvm-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-expensive-checks-debian` running on `gribozavr4` while building `llvm` at step 6 "test-build-unified-tree-check-all".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/16/builds/21604

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 6 (test-build-unified-tree-check-all) failure: test (failure)
******************** TEST 'LLVM :: Transforms/EmbedBitcode/embed-wpd.ll' FAILED ********************
Exit Code: 2

Command Output (stderr):
--
/b/1/llvm-clang-x86_64-expensive-checks-debian/build/bin/opt --mtriple x86_64-unknown-linux-gnu < /b/1/llvm-clang-x86_64-expensive-checks-debian/llvm-project/llvm/test/Transforms/EmbedBitcode/embed-wpd.ll -passes="embed-bitcode<thinlto>" -S | /b/1/llvm-clang-x86_64-expensive-checks-debian/build/bin/FileCheck /b/1/llvm-clang-x86_64-expensive-checks-debian/llvm-project/llvm/test/Transforms/EmbedBitcode/embed-wpd.ll # RUN: at line 1
+ /b/1/llvm-clang-x86_64-expensive-checks-debian/build/bin/opt --mtriple x86_64-unknown-linux-gnu '-passes=embed-bitcode<thinlto>' -S
+ /b/1/llvm-clang-x86_64-expensive-checks-debian/build/bin/FileCheck /b/1/llvm-clang-x86_64-expensive-checks-debian/llvm-project/llvm/test/Transforms/EmbedBitcode/embed-wpd.ll
LLVM ERROR: Module changed by EmbedBitcodePass without invalidating analyses
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
Stack dump:
0.	Program arguments: /b/1/llvm-clang-x86_64-expensive-checks-debian/build/bin/opt --mtriple x86_64-unknown-linux-gnu -passes=embed-bitcode<thinlto> -S
1.	Running pass "embed-bitcode" on module "<stdin>"
 #0 0x0000000004ae3aa7 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/b/1/llvm-clang-x86_64-expensive-checks-debian/build/bin/opt+0x4ae3aa7)
 #1 0x0000000004ae1595 llvm::sys::RunSignalHandlers() (/b/1/llvm-clang-x86_64-expensive-checks-debian/build/bin/opt+0x4ae1595)
 #2 0x0000000004ae41aa SignalHandler(int, siginfo_t*, void*) Signals.cpp:0:0
 #3 0x00007fc5bf8c0140 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x13140)
 #4 0x00007fc5bf3d4d61 raise (/lib/x86_64-linux-gnu/libc.so.6+0x38d61)
 #5 0x00007fc5bf3be537 abort (/lib/x86_64-linux-gnu/libc.so.6+0x22537)
 #6 0x0000000004a42bfa llvm::report_fatal_error(llvm::Twine const&, bool) (/b/1/llvm-clang-x86_64-expensive-checks-debian/build/bin/opt+0x4a42bfa)
 #7 0x00000000026c5a5a void llvm::detail::UniqueFunctionBase<void, llvm::StringRef, llvm::Any, llvm::PreservedAnalyses const&>::CallImpl<llvm::PreservedCFGCheckerInstrumentation::registerCallbacks(llvm::PassInstrumentationCallbacks&, llvm::AnalysisManager<llvm::Module>&)::$_18>(void*, llvm::StringRef, llvm::Any&, llvm::PreservedAnalyses const&) StandardInstrumentations.cpp:0:0
 #8 0x00000000048ff68f llvm::PassManager<llvm::Module, llvm::AnalysisManager<llvm::Module>>::run(llvm::Module&, llvm::AnalysisManager<llvm::Module>&) (/b/1/llvm-clang-x86_64-expensive-checks-debian/build/bin/opt+0x48ff68f)
 #9 0x00000000008adbcd llvm::runPassPipeline(llvm::StringRef, llvm::Module&, llvm::TargetMachine*, llvm::TargetLibraryInfoImpl*, llvm::ToolOutputFile*, llvm::ToolOutputFile*, llvm::ToolOutputFile*, llvm::StringRef, llvm::ArrayRef<llvm::PassPlugin>, llvm::ArrayRef<std::function<void (llvm::PassBuilder&)>>, llvm::opt_tool::OutputKind, llvm::opt_tool::VerifierKind, bool, bool, bool, bool, bool, bool, bool) (/b/1/llvm-clang-x86_64-expensive-checks-debian/build/bin/opt+0x8adbcd)
#10 0x00000000008a35c7 optMain (/b/1/llvm-clang-x86_64-expensive-checks-debian/build/bin/opt+0x8a35c7)
#11 0x00007fc5bf3bfd7a __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x23d7a)
#12 0x000000000089f5aa _start (/b/1/llvm-clang-x86_64-expensive-checks-debian/build/bin/opt+0x89f5aa)
FileCheck error: '<stdin>' is empty.
FileCheck command line:  /b/1/llvm-clang-x86_64-expensive-checks-debian/build/bin/FileCheck /b/1/llvm-clang-x86_64-expensive-checks-debian/llvm-project/llvm/test/Transforms/EmbedBitcode/embed-wpd.ll

--

********************


```

</details>

https://github.com/llvm/llvm-project/pull/145987