[llvm] [BOLT][test] Fix NFC mismatches in perf2bolt tests (PR #146148)
via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 27 12:44:55 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-bolt
Author: Amir Ayupov (aaupov)
<details>
<summary>Changes</summary>
zero-density.s causes spurious NFC mismatches, e.g.
https://lab.llvm.org/buildbot/#/builders/92/builds/21380
This is caused by NFC script wrapping llvm-bolt binary only, so that
perf2bolt invocations are replaced by `llvm-bolt --agregate-only` to
achieve perf2bolt behavior. Add `show-density` to the list of flags
wrapping perf2bolt calls to avoid similar issues in the future.
Test Plan:
```
$ bolt/utils/nfc-check-setup.py --switch-back
$ bin/llvm-lit -a tools/bolt/test/X86/zero-density.s
```
---
Full diff: https://github.com/llvm/llvm-project/pull/146148.diff
1 Files Affected:
- (modified) bolt/utils/llvm-bolt-wrapper.py (+1-1)
``````````diff
diff --git a/bolt/utils/llvm-bolt-wrapper.py b/bolt/utils/llvm-bolt-wrapper.py
index b9d6fad825e78..b913394bce659 100755
--- a/bolt/utils/llvm-bolt-wrapper.py
+++ b/bolt/utils/llvm-bolt-wrapper.py
@@ -79,7 +79,7 @@ def get_cfg(key):
# perf2bolt mode
-PERF2BOLT_MODE = ["-aggregate-only", "-ignore-build-id"]
+PERF2BOLT_MODE = ["-aggregate-only", "-ignore-build-id", "-show-density"]
# boltdiff mode
BOLTDIFF_MODE = ["-diff-only", "-o", "/dev/null"]
``````````
</details>
https://github.com/llvm/llvm-project/pull/146148
More information about the llvm-commits
mailing list