[llvm] [DA] Let getConstantPart return optional APInt (NFC) (PR #146135)
Ramkumar Ramachandra via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 27 12:31:26 PDT 2025
artagnon wrote:
> The goal of this change is to extract the common logic, right? If so, should we return the absolute value of the APInt instead?
I would prefer not to return the absolute value, as it would violate the meaning of the function name. There is already precedent for returning an APInt from a SCEVConstant like in SCEVPatternMatch (although it would be best not to use SCEVPatternMatch in DA).
https://github.com/llvm/llvm-project/pull/146135
More information about the llvm-commits
mailing list