[lld] [llvm] [Hexagon][llvm-objdump] Improve disassembly of Hexagon bundles (PR #145807)

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 26 21:48:00 PDT 2025


================
@@ -693,6 +693,32 @@ class PrettyPrinter {
     } else
       OS << "\t<unknown>";
   }
+
+  virtual std::string getInstructionSeparator() const { return "\n"; }
+
+  virtual void emitPostInstructionInfo(formatted_raw_ostream &FOS,
+                                       const MCAsmInfo &MAI,
+                                       const MCSubtargetInfo &STI,
+                                       StringRef Comments,
+                                       LiveVariablePrinter &LVP) {
+    do {
+      if (!Comments.empty()) {
----------------
MaskRay wrote:

If Comments is a multi-line comment, `getInstructionSeparator();` will be printed multiple times, which is not correct. 

This is a case where we should probably just duplicate emitPostInstructionInfo for Hexagon and not introduce a new virtual function `getInstructionSeparator`


https://github.com/llvm/llvm-project/pull/145807


More information about the llvm-commits mailing list