[llvm] ad6b597 - [ORC] Fix EPCGenericMemoryAccessTest write-ptrs implementation after f93df5ebd99
Lang Hames via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 26 19:09:07 PDT 2025
Author: Lang Hames
Date: 2025-06-27T12:08:25+10:00
New Revision: ad6b597875b9d3523b4466a4c62b4c9d55940b79
URL: https://github.com/llvm/llvm-project/commit/ad6b597875b9d3523b4466a4c62b4c9d55940b79
DIFF: https://github.com/llvm/llvm-project/commit/ad6b597875b9d3523b4466a4c62b4c9d55940b79.diff
LOG: [ORC] Fix EPCGenericMemoryAccessTest write-ptrs implementation after f93df5ebd99
The write-pointers operation should be writing a pointer, not a uint64_t. This
bug existed prior to f93df5ebd99, but changes in that commit seem to have
exposed the issue (see e.g.
https://lab.llvm.org/buildbot/#/builders/154/builds/17956).
Added:
Modified:
llvm/unittests/ExecutionEngine/Orc/EPCGenericMemoryAccessTest.cpp
Removed:
################################################################################
diff --git a/llvm/unittests/ExecutionEngine/Orc/EPCGenericMemoryAccessTest.cpp b/llvm/unittests/ExecutionEngine/Orc/EPCGenericMemoryAccessTest.cpp
index 9358ea8149e95..2bcff3356b86d 100644
--- a/llvm/unittests/ExecutionEngine/Orc/EPCGenericMemoryAccessTest.cpp
+++ b/llvm/unittests/ExecutionEngine/Orc/EPCGenericMemoryAccessTest.cpp
@@ -34,7 +34,7 @@ CWrapperFunctionResult testWritePointers(const char *ArgData, size_t ArgSize) {
handle(ArgData, ArgSize,
[](std::vector<tpctypes::PointerWrite> Ws) {
for (auto &W : Ws)
- *W.Addr.template toPtr<uint64_t *>() = W.Value.getValue();
+ *W.Addr.template toPtr<void **>() = W.Value.toPtr<void *>();
})
.release();
}
More information about the llvm-commits
mailing list