[clang] [llvm] [NFC][analyzer] Remove Z3-as-constraint-manager hacks from lit test code (PR #145731)

[Michał Górny via llvm-commits]

mgorny wrote:

This change broke standalone clang builds:

```
FAIL: Clang :: Analysis/z3/D83660.c (1480 of 21630)
******************** TEST 'Clang :: Analysis/z3/D83660.c' FAILED ********************
Exit Code: 1

Command Output (stderr):
--
rm -rf /var/tmp/portage/llvm-core/clang-21.0.0.9999/work/x/y/clang-abi_x86_32.x86/test/Analysis/z3/Output/D83660.c.tmp && mkdir /var/tmp/portage/llvm-core/clang-21.0.0.9999/work/x/y/clang-abi_x86_32.x86/test/Analysis/z3/Output/D83660.c.tmp # RUN: at line 1
+ rm -rf /var/tmp/portage/llvm-core/clang-21.0.0.9999/work/x/y/clang-abi_x86_32.x86/test/Analysis/z3/Output/D83660.c.tmp
+ mkdir /var/tmp/portage/llvm-core/clang-21.0.0.9999/work/x/y/clang-abi_x86_32.x86/test/Analysis/z3/Output/D83660.c.tmp
/usr/lib/ccache/bin/x86_64-pc-linux-gnu-g++ -shared -fPIC -I     /var/tmp/portage/llvm-core/clang-21.0.0.9999/work/clang/test/Analysis/z3/Inputs/MockZ3_solver_check.cpp    -o /var/tmp/portage/llvm-core/clang-21.0.0.9999/work/x/y/clang-abi_x86_32.x86/test/Analysis/z3/Output/D83660.c.tmp/MockZ3_solver_check.so # RUN: at line 2
+ /usr/lib/ccache/bin/x86_64-pc-linux-gnu-g++ -shared -fPIC -I /var/tmp/portage/llvm-core/clang-21.0.0.9999/work/clang/test/Analysis/z3/Inputs/MockZ3_solver_check.cpp -o /var/tmp/portage/llvm-core/clang-21.0.0.9999/work/x/y/clang-abi_x86_32.x86/test/Analysis/z3/Output/D83660.c.tmp/MockZ3_solver_check.so
x86_64-pc-linux-gnu-g++: fatal error: no input files
compilation terminated.

--

********************
******************** TEST 'Clang :: Analysis/z3-crosscheck-max-attempts.cpp' FAILED ********************                               
Exit Code: 1                                                                                                                           
                                                                                                                                       
Command Output (stderr):                                                                                                               
--                                                                                                                                     
/var/tmp/portage/llvm-core/clang-21.0.0.9999/work/x/y/clang-abi_x86_32.x86/bin/clang -cc1 -internal-isystem /var/tmp/portage/llvm-core/clang-21.0.0.9999/work/x/y/clang-abi_x86_32.x86/bin/../../../../lib/clang/21/include -nostdsysteminc -analyze -setup-static-analyzer -analyzer-checker=debug.ConfigDumper 2>&1  | /usr/lib/llvm/21/bin/FileCheck /var/tmp/portage/llvm-core/clang-21.0.0.9999/work/clang/test/Analysis/z3-crosscheck-max-attempts.cpp --match-full-lines # RUN: at line 2                                                            
+ /var/tmp/portage/llvm-core/clang-21.0.0.9999/work/x/y/clang-abi_x86_32.x86/bin/clang -cc1 -internal-isystem /var/tmp/portage/llvm-core/clang-21.0.0.9999/work/x/y/clang-abi_x86_32.x86/bin/../../../../lib/clang/21/include -nostdsysteminc -analyze -setup-static-analyzer -analyzer-checker=debug.ConfigDumper                                                                                                   
+ /usr/lib/llvm/21/bin/FileCheck /var/tmp/portage/llvm-core/clang-21.0.0.9999/work/clang/test/Analysis/z3-crosscheck-max-attempts.cpp --match-full-lines                                                                                                                      
rm -rf /var/tmp/portage/llvm-core/clang-21.0.0.9999/work/x/y/clang-abi_x86_32.x86/test/Analysis/Output/z3-crosscheck-max-attempts.cpp.tmp && mkdir /var/tmp/portage/llvm-core/clang-21.0.0.9999/work/x/y/clang-abi_x86_32.x86/test/Analysis/Output/z3-crosscheck-max-attempts.cpp.tmp # RUN: at line 6                                                                                                               
+ rm -rf /var/tmp/portage/llvm-core/clang-21.0.0.9999/work/x/y/clang-abi_x86_32.x86/test/Analysis/Output/z3-crosscheck-max-attempts.cpp.tmp                                                                                                                                   
+ mkdir /var/tmp/portage/llvm-core/clang-21.0.0.9999/work/x/y/clang-abi_x86_32.x86/test/Analysis/Output/z3-crosscheck-max-attempts.cpp.tmp                                                                                                                                    
/usr/lib/ccache/bin/x86_64-pc-linux-gnu-g++ -shared -fPIC -I            /var/tmp/portage/llvm-core/clang-21.0.0.9999/work/clang/test/Analysis/z3/Inputs/MockZ3_solver_check.cpp               -o /var/tmp/portage/llvm-core/clang-21.0.0.9999/work/x/y/clang-abi_x86_32.x86/test/Analysis/Output/z3-crosscheck-max-attempts.cpp.tmp/MockZ3_solver_check.so # RUN: at line 7                                          
+ /usr/lib/ccache/bin/x86_64-pc-linux-gnu-g++ -shared -fPIC -I /var/tmp/portage/llvm-core/clang-21.0.0.9999/work/clang/test/Analysis/z3/Inputs/MockZ3_solver_check.cpp -o /var/tmp/portage/llvm-core/clang-21.0.0.9999/work/x/y/clang-abi_x86_32.x86/test/Analysis/Output/z3-crosscheck-max-attempts.cpp.tmp/MockZ3_solver_check.so                                                                                  
x86_64-pc-linux-gnu-g++: fatal error: no input files                                                                                   
compilation terminated.                                                                                                                
                                                                                                                                       
--                                                                                                                                     
                                                                                                                                       
******************** 
```

FWICS the problem is that `Z3_INCLUDE_DIR` is not set in `clang`.

https://github.com/llvm/llvm-project/pull/145731