[llvm] 4233ca1 - [OMPIRBuilder] Fix use of uninitialized variable. (#145883)

via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 26 08:11:02 PDT 2025


Author: Abid Qadeer
Date: 2025-06-26T16:10:58+01:00
New Revision: 4233ca1e4e53f91c2ac9a40ef79ce8fa17acc03a

URL: https://github.com/llvm/llvm-project/commit/4233ca1e4e53f91c2ac9a40ef79ce8fa17acc03a
DIFF: https://github.com/llvm/llvm-project/commit/4233ca1e4e53f91c2ac9a40ef79ce8fa17acc03a.diff

LOG: [OMPIRBuilder] Fix use of uninitialized variable. (#145883)

The code in `OpenMPIRBuilder::getTargetEntryUniqueInfo` calls
`ID.getDevice()` even when `getUniqueID` has failed and ID is
un-initialized. This caused a sanitizer fail for me in
https://github.com/llvm/llvm-project/pull/145026. Fix it by giving a
default value to `ID`. The value chosen is the same as used in
`OpenMPToLLVMIRTranslation.cpp`.

Added: 
    

Modified: 
    llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp b/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
index d4f95be083a47..85451b1233f96 100644
--- a/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
+++ b/llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp
@@ -9846,7 +9846,7 @@ void OffloadEntriesInfoManager::getTargetRegionEntryFnName(
 TargetRegionEntryInfo
 OpenMPIRBuilder::getTargetEntryUniqueInfo(FileIdentifierInfoCallbackTy CallBack,
                                           StringRef ParentName) {
-  sys::fs::UniqueID ID;
+  sys::fs::UniqueID ID(0xdeadf17e, 0);
   auto FileIDInfo = CallBack();
   uint64_t FileID = 0;
   std::error_code EC = sys::fs::getUniqueID(std::get<0>(FileIDInfo), ID);


        


More information about the llvm-commits mailing list