[llvm] Minimal unwinding information (DWARF CFI) checker (PR #145633)
Simon Tatham via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 26 05:04:44 PDT 2025
================
@@ -0,0 +1,49 @@
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+///
+/// \file
+/// This file declares CFIFunctionFrameReceiver class.
----------------
statham-arm wrote:
It's difficult to read all of this new code without an overview of what all these classes are _for_. Could you expand the comments in your new header files to describe the purpose of each class, not just its name?
Here, for example, it looks as if `CFIFunctionFrameReceiver` does basically nothing, because it's just a base class. Some other class (which?) will be given a pointer to an instance of this base class, and will send it information about a function it's scanning, but really the pointer will point to a subclass which actually does something with the information.
But I had to look in the implementation source file to confirm that, by seeing that all the methods are empty.
https://github.com/llvm/llvm-project/pull/145633
More information about the llvm-commits
mailing list