[llvm] Add modified runtimes back to runtimes_to_{test|build} (PR #145805)
Amy Huang via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 25 15:52:25 PDT 2025
https://github.com/amykhuang created https://github.com/llvm/llvm-project/pull/145805
It seems like runtimes like libc and libc++ no longer get tested when their files are modified, so adding them back into the "runtimes_to_test" computation.
>From 1439736bf21d88d945ca4f68095217478050e706 Mon Sep 17 00:00:00 2001
From: Amy Huang <akhuang at google.com>
Date: Wed, 25 Jun 2025 15:41:15 -0700
Subject: [PATCH] Add modified runtimes back to runtimes_to_build
---
.ci/compute_projects.py | 2 ++
.ci/compute_projects_test.py | 6 +++---
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/.ci/compute_projects.py b/.ci/compute_projects.py
index 80e4e0221b3d7..a0f29d6b393e2 100644
--- a/.ci/compute_projects.py
+++ b/.ci/compute_projects.py
@@ -229,6 +229,8 @@ def _compute_runtimes_to_build(
for modified_project in modified_projects:
if modified_project in DEPENDENT_RUNTIMES_TO_BUILD:
runtimes_to_build.update(DEPENDENT_RUNTIMES_TO_BUILD[modified_project])
+ if modified_project in RUNTIMES:
+ runtimes_to_build.add(modified_project)
return _exclude_projects(runtimes_to_build, platform)
diff --git a/.ci/compute_projects_test.py b/.ci/compute_projects_test.py
index 5efac26366981..439fb95f3bda3 100644
--- a/.ci/compute_projects_test.py
+++ b/.ci/compute_projects_test.py
@@ -187,14 +187,14 @@ def test_top_level_file(self):
self.assertEqual(env_variables["runtimes_check_targets"], "")
self.assertEqual(env_variables["runtimes_check_targets_needs_reconfig"], "")
- def test_exclude_runtiems_in_projects(self):
+ def test_exclude_runtimes_in_projects(self):
env_variables = compute_projects.get_env_variables(
["libcxx/CMakeLists.txt"], "Linux"
)
self.assertEqual(env_variables["projects_to_build"], "")
self.assertEqual(env_variables["project_check_targets"], "")
- self.assertEqual(env_variables["runtimes_to_build"], "")
- self.assertEqual(env_variables["runtimes_check_targets"], "")
+ self.assertEqual(env_variables["runtimes_to_build"], "libcxx")
+ self.assertEqual(env_variables["runtimes_check_targets"], "check-cxx")
self.assertEqual(env_variables["runtimes_check_targets_needs_reconfig"], "")
def test_exclude_docs(self):
More information about the llvm-commits
mailing list