[llvm] [Hexagaon] Remove emplace workaround (NFC) (PR #145718)

via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 25 08:06:59 PDT 2025


https://github.com/AZero13 created https://github.com/llvm/llvm-project/pull/145718

It was done because it was not supported in gcc 4.7.4.

>From dc14ccb68f4168bcf0ca8a05ee5ac4fb77ee977e Mon Sep 17 00:00:00 2001
From: Rose <gfunni234 at gmail.com>
Date: Wed, 25 Jun 2025 11:06:34 -0400
Subject: [PATCH] [Hexagaon] Remove emplace workaround (NFC)

It was done because it was not supported in gcc 4.7.4.
---
 llvm/lib/Target/Hexagon/HexagonFrameLowering.cpp | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/llvm/lib/Target/Hexagon/HexagonFrameLowering.cpp b/llvm/lib/Target/Hexagon/HexagonFrameLowering.cpp
index b75c8863b6999..b3c61e1829bf9 100644
--- a/llvm/lib/Target/Hexagon/HexagonFrameLowering.cpp
+++ b/llvm/lib/Target/Hexagon/HexagonFrameLowering.cpp
@@ -2196,10 +2196,7 @@ void HexagonFrameLowering::optimizeSpillSlots(MachineFunction &MF,
   // and collect relevant information.
   for (auto &B : MF) {
     std::map<int,IndexType> LastStore, LastLoad;
-    // Emplace appears not to be supported in gcc 4.7.2-4.
-    //auto P = BlockIndexes.emplace(&B, HexagonBlockRanges::InstrIndexMap(B));
-    auto P = BlockIndexes.insert(
-                std::make_pair(&B, HexagonBlockRanges::InstrIndexMap(B)));
+    auto P = BlockIndexes.emplace(&B, HexagonBlockRanges::InstrIndexMap(B));
     auto &IndexMap = P.first->second;
     LLVM_DEBUG(dbgs() << "Index map for " << printMBBReference(B) << "\n"
                       << IndexMap << '\n');



More information about the llvm-commits mailing list