[llvm] AArch64: Do not use report_fatal_error for pauth reloc errors (PR #145277)

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 24 08:45:23 PDT 2025


arsenm wrote:

> @arsenm Your PR description says that the wording does not follow the error message guidance, but I do not see any changes in wording in this PR - have you forgotten to add these?

No, this was general commentary on the error, I wasn't trying to rephrase these here

> 
> > The wording doesn't follow the error message guidance
> 
> Also, I actually am not sure if the messages contradict with existig style. Corresponding section in docs is pretty short https://llvm.org/docs/CodingStandards.html#error-and-warning-messages. But, there are many existing errors like "XXX out of range" across llvm codebase. I don't mind changing the wording, I'm just not sure that current choice is not suitable.

Starts with capital letter, also naming the architecture is kind of weird. Also should probably spell out PAC, and I'm not sure how to interpret either of these numbers. We probably should have some kind of phrasing guidance on how to express out of bounds


https://github.com/llvm/llvm-project/pull/145277


More information about the llvm-commits mailing list