[llvm] 6cfa03f - [ORC] Drop unused LinkGraphLinkingLayer::Plugin::notifyLoaded method. (#145457)

[via llvm-commits]

Author: Lang Hames
Date: 2025-06-24T19:00:24+10:00
New Revision: 6cfa03f1f1d9351950b6d12fb923ce7e2cb3405b

URL: https://github.com/llvm/llvm-project/commit/6cfa03f1f1d9351950b6d12fb923ce7e2cb3405b
DIFF: https://github.com/llvm/llvm-project/commit/6cfa03f1f1d9351950b6d12fb923ce7e2cb3405b.diff

LOG: [ORC] Drop unused LinkGraphLinkingLayer::Plugin::notifyLoaded method. (#145457)

This method was included in the original Plugin API as a counterpart to
JITEventListener::notifyLoaded but was never used.

Added: 
    

Modified: 
    llvm/examples/OrcV2Examples/LLJITWithObjectLinkingLayerPlugin/LLJITWithObjectLinkingLayerPlugin.cpp
    llvm/include/llvm/ExecutionEngine/Orc/LinkGraphLinkingLayer.h
    llvm/lib/ExecutionEngine/Orc/LinkGraphLinkingLayer.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/examples/OrcV2Examples/LLJITWithObjectLinkingLayerPlugin/LLJITWithObjectLinkingLayerPlugin.cpp b/llvm/examples/OrcV2Examples/LLJITWithObjectLinkingLayerPlugin/LLJITWithObjectLinkingLayerPlugin.cpp
index d955b65c349fa..fd693699b768b 100644
--- a/llvm/examples/OrcV2Examples/LLJITWithObjectLinkingLayerPlugin/LLJITWithObjectLinkingLayerPlugin.cpp
+++ b/llvm/examples/OrcV2Examples/LLJITWithObjectLinkingLayerPlugin/LLJITWithObjectLinkingLayerPlugin.cpp
@@ -70,10 +70,6 @@ class MyPlugin : public ObjectLinkingLayer::Plugin {
     Config.PostPrunePasses.push_back(printGraph);
   }
 
-  void notifyLoaded(MaterializationResponsibility &MR) override {
-    outs() << "Loading object defining " << MR.getSymbols() << "\n";
-  }
-
   Error notifyEmitted(MaterializationResponsibility &MR) override {
     outs() << "Emitted object defining " << MR.getSymbols() << "\n";
     return Error::success();

diff  --git a/llvm/include/llvm/ExecutionEngine/Orc/LinkGraphLinkingLayer.h b/llvm/include/llvm/ExecutionEngine/Orc/LinkGraphLinkingLayer.h
index b3d7500dd37ef..d3643f9301134 100644
--- a/llvm/include/llvm/ExecutionEngine/Orc/LinkGraphLinkingLayer.h
+++ b/llvm/include/llvm/ExecutionEngine/Orc/LinkGraphLinkingLayer.h
@@ -63,7 +63,6 @@ class LLVM_ABI LinkGraphLinkingLayer : public LinkGraphLayer,
                                      jitlink::JITLinkContext &Ctx,
                                      MemoryBufferRef InputObject) {}
 
-    virtual void notifyLoaded(MaterializationResponsibility &MR) {}
     virtual Error notifyEmitted(MaterializationResponsibility &MR) {
       return Error::success();
     }

diff  --git a/llvm/lib/ExecutionEngine/Orc/LinkGraphLinkingLayer.cpp b/llvm/lib/ExecutionEngine/Orc/LinkGraphLinkingLayer.cpp
index edb29d99f47bb..d1a6eaf914a78 100644
--- a/llvm/lib/ExecutionEngine/Orc/LinkGraphLinkingLayer.cpp
+++ b/llvm/lib/ExecutionEngine/Orc/LinkGraphLinkingLayer.cpp
@@ -207,7 +207,6 @@ class LinkGraphLinkingLayer::JITLinkCtx final : public JITLinkContext {
     if (auto Err = MR->notifyResolved(InternedResult))
       return Err;
 
-    notifyLoaded();
     return Error::success();
   }
 
@@ -244,11 +243,6 @@ class LinkGraphLinkingLayer::JITLinkCtx final : public JITLinkContext {
     return Error::success();
   }
 
-  void notifyLoaded() {
-    for (auto &P : Plugins)
-      P->notifyLoaded(*MR);
-  }
-
   Error notifyEmitted(jitlink::JITLinkMemoryManager::FinalizedAlloc FA) {
     Error Err = Error::success();
     for (auto &P : Plugins)