[llvm] [NVPTX] fold movs into loads and stores (PR #144581)

Artem Belevich via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 23 11:19:25 PDT 2025


================
@@ -3511,9 +3511,6 @@ SDValue NVPTXTargetLowering::LowerFormalArguments(
                               Elt);
           } else if (ExpactedVT.bitsLT(Elt.getValueType())) {
             Elt = DAG.getNode(ISD::TRUNCATE, dl, ExpactedVT, Elt);
-          } else {
-            // v2f16 was loaded as an i32. Now we must bitcast it back.
-            Elt = DAG.getBitcast(EltVT, Elt);
           }
----------------
Artem-B wrote:

<!--__GRAPHITE_HTML_TAG_START__--><p class='graphite__hidden'><i>[Re: lines +3509 to +3514]</i></p><!--__GRAPHITE_HTML_TAG_END__-->
Nit: no need for `{}` around single-statement bodies.
<!--__GRAPHITE_HTML_TAG_START__--><p class='graphite__hidden'>See this comment inline on <a href="https://app.graphite.dev/github/pr/llvm/llvm-project/144581?utm_source=unchanged-line-comment">Graphite</a>.</p><!--__GRAPHITE_HTML_TAG_END__-->

https://github.com/llvm/llvm-project/pull/144581


More information about the llvm-commits mailing list