[llvm] [KeyInstr] Use DISubprogram's is-key-instructions-on flag at DWARF emission (PR #144104)

Jeremy Morse via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 23 04:27:04 PDT 2025


================
@@ -2077,8 +2079,17 @@ void DwarfDebug::beginInstruction(const MachineInstr *MI) {
   unsigned LastAsmLine =
       Asm->OutStreamer->getContext().getCurrentDwarfLoc().getLine();
 
----------------
jmorse wrote:

This is an immense nitpick, but IMO the comment should open by stating the premise "There may be a mixture of scopes using KIs, and not using KIs" or something similar. It's sufficiently non-obvious that it should be made explicit to the future reader.

https://github.com/llvm/llvm-project/pull/144104


More information about the llvm-commits mailing list