[llvm] [Offload] Fix type mismatch warning in test (PR #143700)

Ross Brunton via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 23 02:03:12 PDT 2025


https://github.com/RossBrunton updated https://github.com/llvm/llvm-project/pull/143700

>From baf5a6e5ff5f4225cd3b2cbf92a7efb479a5e69c Mon Sep 17 00:00:00 2001
From: Ross Brunton <ross at codeplay.com>
Date: Wed, 11 Jun 2025 14:17:11 +0100
Subject: [PATCH 1/2] [Offload] Fix type mismatch warning in test

---
 offload/unittests/OffloadAPI/kernel/olLaunchKernel.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/offload/unittests/OffloadAPI/kernel/olLaunchKernel.cpp b/offload/unittests/OffloadAPI/kernel/olLaunchKernel.cpp
index 157f33a363700..ab82088a3576b 100644
--- a/offload/unittests/OffloadAPI/kernel/olLaunchKernel.cpp
+++ b/offload/unittests/OffloadAPI/kernel/olLaunchKernel.cpp
@@ -66,7 +66,7 @@ TEST_P(olLaunchKernelTest, Success) {
   ASSERT_SUCCESS(olWaitQueue(Queue));
 
   uint32_t *Data = (uint32_t *)Mem;
-  for (int i = 0; i < 64; i++) {
+  for (uint32_t i = 0; i < 64; i++) {
     ASSERT_EQ(Data[i], i);
   }
 

>From bb58348a3533d2f9dcc16491e5923ad0dc91ab72 Mon Sep 17 00:00:00 2001
From: Ross Brunton <ross at codeplay.com>
Date: Mon, 23 Jun 2025 10:02:54 +0100
Subject: [PATCH 2/2] Add additional warning that snuck in

---
 offload/unittests/OffloadAPI/kernel/olLaunchKernel.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/offload/unittests/OffloadAPI/kernel/olLaunchKernel.cpp b/offload/unittests/OffloadAPI/kernel/olLaunchKernel.cpp
index ab82088a3576b..a3da334afccac 100644
--- a/offload/unittests/OffloadAPI/kernel/olLaunchKernel.cpp
+++ b/offload/unittests/OffloadAPI/kernel/olLaunchKernel.cpp
@@ -93,7 +93,7 @@ TEST_P(olLaunchKernelTest, SuccessSynchronous) {
                                 &LaunchArgs, nullptr));
 
   uint32_t *Data = (uint32_t *)Mem;
-  for (int i = 0; i < 64; i++) {
+  for (uint32_t i = 0; i < 64; i++) {
     ASSERT_EQ(Data[i], i);
   }
 



More information about the llvm-commits mailing list