[llvm] [HashRecognize] Rewrite arePHIsIntertwined (PR #144878)

Piotr Fusik via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 23 01:29:46 PDT 2025


https://github.com/pfusik commented:

This checks if `Needle` and `Reference` are used in a `BinaryOperator`, one directly, one indirectly: through `zext` or `trunc`.
What's the point if we don't check what the `BinaryOperator` is later used for?
There's also no check for `trunc` possibly stripping significant bits.

Also, what's the use case for `BoToMatch == Instruction::BinaryOpsEnd` ?

https://github.com/llvm/llvm-project/pull/144878


More information about the llvm-commits mailing list