[llvm] [feature][riscv] handle target address calculation in llvm-objdump disassembly for riscv (PR #144620)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 23 00:26:31 PDT 2025


================
@@ -234,6 +243,91 @@ class RISCVMCInstrAnalysis : public MCInstrAnalysis {
     return false;
   }
 
+  bool evaluateInstruction(const MCInst &Inst, uint64_t Addr, uint64_t Size,
----------------
jh7370 wrote:

Why is this a distinct function to `evaluateBranch` in the virtual interface? It feels like the two are fundamentally the same from a high-level point of view, since a branch is an instruction. Of course, within the target-specific layer, you could split it then.

If the purpose is purely so you know when a thing is branch specifically, it feels like you could achieve that through some other means, for example an enum return code that has values like `Invalid`, `Branch`, `Other`, or maybe a bitfield with some basic flags.

https://github.com/llvm/llvm-project/pull/144620


More information about the llvm-commits mailing list