[llvm] db051e8 - AsmPrinter: Do not use report_fatal_error for unknown appending linkage (#145269)

[via llvm-commits]

Author: Matt Arsenault
Date: 2025-06-23T16:26:27+09:00
New Revision: db051e8800d33247625280328c6759e411f62421

URL: https://github.com/llvm/llvm-project/commit/db051e8800d33247625280328c6759e411f62421
DIFF: https://github.com/llvm/llvm-project/commit/db051e8800d33247625280328c6759e411f62421.diff

LOG: AsmPrinter: Do not use report_fatal_error for unknown appending linkage (#145269)

Added: 
    

Modified: 
    llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
    llvm/test/CodeGen/X86/AppendingLinkage.ll

Removed: 
    


################################################################################
diff  --git a/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp b/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
index 541373520ffb0..837be95b42aa3 100644
--- a/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
+++ b/llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
@@ -3207,7 +3207,10 @@ bool AsmPrinter::emitSpecialLLVMGlobal(const GlobalVariable *GV) {
     return true;
   }
 
-  report_fatal_error("unknown special variable with appending linkage");
+  GV->getContext().emitError(
+      "unknown special variable with appending linkage: " +
+      GV->getNameOrAsOperand());
+  return true;
 }
 
 /// EmitLLVMUsedList - For targets that define a MAI::UsedDirective, mark each

diff  --git a/llvm/test/CodeGen/X86/AppendingLinkage.ll b/llvm/test/CodeGen/X86/AppendingLinkage.ll
index ace5d192b7ea7..77d1ce4a21481 100644
--- a/llvm/test/CodeGen/X86/AppendingLinkage.ll
+++ b/llvm/test/CodeGen/X86/AppendingLinkage.ll
@@ -1,4 +1,7 @@
-; RUN: not --crash llc < %s -mtriple=i686-- 2>&1 | FileCheck %s
+; RUN: not llc < %s -mtriple=i686-- 2>&1 | FileCheck %s
 
-; CHECK: unknown special variable with appending linkage
- at foo = appending constant [1 x i32 ]zeroinitializer
+; CHECK: error: unknown special variable with appending linkage: foo
+ at foo = appending constant [1 x i32 ] zeroinitializer
+
+; CHECK: error: unknown special variable with appending linkage: @0
+ at 0 = appending constant [1 x i32 ] zeroinitializer