[llvm] [TableGen] Avoid evaluating RHS of a BinOp until short-circuit is complete (PR #144021)

Jason Eckhardt via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 13 07:34:08 PDT 2025


================
@@ -1577,6 +1576,8 @@ const Init *BinOpInit::resolveReferences(Resolver &R) const {
     }
   }
 
+  const Init *rhs = RHS->resolveReferences(R);
+
----------------
nvjle wrote:

Nit: As long as we're in the area, can we update the non-conforming `rhs` and `lhs` to, e.g., `NewRHS` and `NewLHS`?

Otherwise, LGTM.

https://github.com/llvm/llvm-project/pull/144021


More information about the llvm-commits mailing list