[llvm] [RISCV] Add GetVTypeMinimalPredicates for the operation supported by zvfhmin. NFC. (PR #143847)

Luke Lau via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 13 02:43:06 PDT 2025


================
@@ -7425,10 +7424,7 @@ defm : VPatBinaryV_VV_INT_EEW<"int_riscv_vrgatherei16_vv", "PseudoVRGATHEREI16",
                               eew=16, vtilist=AllIntegerVectors>;
 
 defm : VPatBinaryV_VV_VX_VI_INT<"int_riscv_vrgather", "PseudoVRGATHER",
-                                AllFloatVectorsExceptFP16, uimm5>;
-let Predicates = [HasVInstructionsF16Minimal] in
-  defm : VPatBinaryV_VV_VX_VI_INT<"int_riscv_vrgather", "PseudoVRGATHER",
-                                  AllFP16Vectors, uimm5>;
----------------
lukel97 wrote:

Ah I see now it's to override `GetVTypePredicates<vti>.Predicates` in `VPatBinaryV_VV_INT`, which would have required `zvfh` otherwise.

But I think this should still be ok if the predicate was just `HasVInstructions`, the actual enablement of the fp16 type is done in RISCVISelLowering.cpp IIUC. 

Nothing needed for this PR, sorry for the noise.

https://github.com/llvm/llvm-project/pull/143847


More information about the llvm-commits mailing list