[llvm] Add --dump-offload-bundle option to llvm-objcopy (PR #143347)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 13 01:09:21 PDT 2025


https://github.com/jh7370 commented:

I don't like the stuff around `NeedPositional` without further explanation, at least. This option doesn't seem semantically all that different to `--dump-section`, which does have require positional arguments. It's also a significant departure from how llvm-objcopy's stated behaviour currently works, which is roughly that it takes an input file, performs some operations on it, then makes a semantic copy of it, storing the copy in either the output file, if specified, or overwriting the input, if not. In this way, I'd expect an offload bundle operation to do the same thing as `--dump-section`, which is to extract the relevant data and store it in a file specified by the option, while the input is copied as before. Otherwise, this raises the question of how other options are supposed to interact with the new option. For example, if you use `--dump-offload-bundle` at the same time as `--remove-section` right now, you wouldn't get an error if there were no positional arguments, which I don't think would be the user's intention.

https://github.com/llvm/llvm-project/pull/143347


More information about the llvm-commits mailing list