https://github.com/wangpc-pp commented: Just a general comment: would the abstraction make the code hard to maintain compared to put X380 model into a standalone file? https://github.com/llvm/llvm-project/pull/143938