[llvm] b6a56b8 - [llvm-remarkutil] bitstream2yaml: Keep output file (#143220)

[via llvm-commits]

Author: Tobias Stadler
Date: 2025-06-12T15:50:31+01:00
New Revision: b6a56b8ef26a6b612eb5f49d37024666b073481e

URL: https://github.com/llvm/llvm-project/commit/b6a56b8ef26a6b612eb5f49d37024666b073481e
DIFF: https://github.com/llvm/llvm-project/commit/b6a56b8ef26a6b612eb5f49d37024666b073481e.diff

LOG: [llvm-remarkutil] bitstream2yaml: Keep output file (#143220)

Keep the output file on successful exit, otherwise `llvm-remarkutil
bitstream2yaml -o filename.yaml ...` does not produce any output,
because the output file is deleted when the tool exits.

Added: 
    

Modified: 
    llvm/test/tools/llvm-remarkutil/convert.test
    llvm/tools/llvm-remarkutil/RemarkConvert.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/test/tools/llvm-remarkutil/convert.test b/llvm/test/tools/llvm-remarkutil/convert.test
index 83023c8ce6a89..0d7ab8e4682a5 100644
--- a/llvm/test/tools/llvm-remarkutil/convert.test
+++ b/llvm/test/tools/llvm-remarkutil/convert.test
@@ -1,6 +1,7 @@
-RUN: llvm-remarkutil bitstream2yaml %p/Inputs/two-remarks.bitstream -o - | FileCheck %s -strict-whitespace
-RUN: llvm-remarkutil yaml2bitstream %p/Inputs/two-remarks.yaml -o %t
-RUN: llvm-remarkutil bitstream2yaml %t -o - | FileCheck %s -strict-whitespace
+RUN: llvm-remarkutil bitstream2yaml %p/Inputs/two-remarks.bitstream -o %t.yaml
+RUN: FileCheck %s -strict-whitespace < %t.yaml
+RUN: llvm-remarkutil yaml2bitstream %p/Inputs/two-remarks.yaml -o %t.bitstream
+RUN: llvm-remarkutil bitstream2yaml %t.bitstream -o - | FileCheck %s -strict-whitespace
 
 ; CHECK: --- !Analysis
 ; CHECK-NEXT: Pass:            prologepilog

diff  --git a/llvm/tools/llvm-remarkutil/RemarkConvert.cpp b/llvm/tools/llvm-remarkutil/RemarkConvert.cpp
index 35d8dcd99b4a9..207c5e0a8048b 100644
--- a/llvm/tools/llvm-remarkutil/RemarkConvert.cpp
+++ b/llvm/tools/llvm-remarkutil/RemarkConvert.cpp
@@ -133,6 +133,7 @@ static Error tryBitstream2YAML() {
   if (!E.isA<EndOfFileError>())
     return E;
   consumeError(std::move(E));
+  OF->keep();
   return Error::success();
 }
 } // namespace bitstream2yaml