[llvm] Add --offoading option to llvm-readobj (PR #143342)
James Henderson via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 12 01:56:04 PDT 2025
https://github.com/jh7370 commented:
Please don't force push to update a PR. Just use fixup commits, per LLVM policy (https://llvm.org/docs/GitHub.html#updating-pull-requests and the following sub-section). If you need to rebase, use a merge commit instead (it'll disappear during the squash & merge). Force pushes prevent me from easily seeing what has changed since the previous version I reviewed.
Also, I'd prefer it if you didn't resolve conversations in GitHub that I've started, as I use unresolved conversations to easily indicate to me whether I've reviewed and am happy with the requested change/resolution etc. [I made a post on Discourse](https://discourse.llvm.org/t/rfc-github-pr-resolve-conversation-button/73178) ages ago about this topic, if you want to read more context.
https://github.com/llvm/llvm-project/pull/143342
More information about the llvm-commits
mailing list