[llvm] [BPF] Reclassify BPF debug info validation failures as usage errors (PR #143777)

[Reid Kleckner via llvm-commits]

https://github.com/rnk created https://github.com/llvm/llvm-project/pull/143777

As discussed in issue #52779, the BPF backend diagnoses certain invalid
uses of intrinsics late, in the backend. This is a bad diagnostic
experience, but the compiler should be teling the user to fix their
code, not to file a bug, so as a stopgap, we should reclassify these
errors as usage errors.

Fixes #143774


>From 88656fa8f4aa128e705f085cc2ea1b8765f41e04 Mon Sep 17 00:00:00 2001
From: Reid Kleckner <rnk at google.com>
Date: Wed, 11 Jun 2025 12:48:11 -0700
Subject: [PATCH] [BPF] Reclassify BPF debug info validation failures as usage
 errors

As discussed in issue #52779, the BPF backend diagnoses certain invalid
uses of intrinsics late, in the backend. This is a bad diagnostic
experience, but the compiler should be teling the user to fix their
code, not to file a bug, so as a stopgap, we should reclassify these
errors as usage errors.

Fixes #143774
---
 llvm/lib/Target/BPF/BPFPreserveDIType.cpp | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/llvm/lib/Target/BPF/BPFPreserveDIType.cpp b/llvm/lib/Target/BPF/BPFPreserveDIType.cpp
index d3b0c0246581b..449aed98a6375 100644
--- a/llvm/lib/Target/BPF/BPFPreserveDIType.cpp
+++ b/llvm/lib/Target/BPF/BPFPreserveDIType.cpp
@@ -58,7 +58,7 @@ static bool BPFPreserveDITypeImpl(Function &F) {
 
       if (GV->getName().starts_with("llvm.bpf.btf.type.id")) {
         if (!Call->getMetadata(LLVMContext::MD_preserve_access_index))
-          report_fatal_error(
+          reportFatalUsageError(
               "Missing metadata for llvm.bpf.btf.type.id intrinsic");
         PreserveDITypeCalls.push_back(Call);
       }
@@ -76,7 +76,8 @@ static bool BPFPreserveDITypeImpl(Function &F) {
     uint64_t FlagValue = Flag->getValue().getZExtValue();
 
     if (FlagValue >= BPFCoreSharedInfo::MAX_BTF_TYPE_ID_FLAG)
-      report_fatal_error("Incorrect flag for llvm.bpf.btf.type.id intrinsic");
+      reportFatalUsageError(
+          "Incorrect flag for llvm.bpf.btf.type.id intrinsic");
 
     MDNode *MD = Call->getMetadata(LLVMContext::MD_preserve_access_index);
 
@@ -97,10 +98,10 @@ static bool BPFPreserveDITypeImpl(Function &F) {
     if (Reloc == BTF::BTF_TYPE_ID_REMOTE) {
       if (Ty->getName().empty()) {
         if (isa<DISubroutineType>(Ty))
-          report_fatal_error(
+          reportFatalUsageError(
               "SubroutineType not supported for BTF_TYPE_ID_REMOTE reloc");
         else
-          report_fatal_error("Empty type name for BTF_TYPE_ID_REMOTE reloc");
+          reportFatalUsageError("Empty type name for BTF_TYPE_ID_REMOTE reloc");
       }
     }
     MD = Ty;