[llvm] [ADT] Simplify SparseBitVectorElement::unionWith and friends. NFC. (PR #143775)
Jay Foad via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 11 12:45:48 PDT 2025
https://github.com/jayfoad created https://github.com/llvm/llvm-project/pull/143775
None
>From 1775d80ec58eeeac8be33498d3ee860ded281e36 Mon Sep 17 00:00:00 2001
From: Jay Foad <jay.foad at amd.com>
Date: Wed, 11 Jun 2025 15:14:46 +0100
Subject: [PATCH] [ADT] Simplify SparseBitVectorElement::unionWith and friends
---
llvm/include/llvm/ADT/SparseBitVector.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/llvm/include/llvm/ADT/SparseBitVector.h b/llvm/include/llvm/ADT/SparseBitVector.h
index 7151af6146e6e..1e6f8b22ca997 100644
--- a/llvm/include/llvm/ADT/SparseBitVector.h
+++ b/llvm/include/llvm/ADT/SparseBitVector.h
@@ -172,10 +172,10 @@ template <unsigned ElementSize = 128> struct SparseBitVectorElement {
bool unionWith(const SparseBitVectorElement &RHS) {
bool changed = false;
for (unsigned i = 0; i < BITWORDS_PER_ELEMENT; ++i) {
- BitWord old = changed ? 0 : Bits[i];
+ BitWord old = Bits[i];
Bits[i] |= RHS.Bits[i];
- if (!changed && old != Bits[i])
+ if (old != Bits[i])
changed = true;
}
return changed;
@@ -199,13 +199,13 @@ template <unsigned ElementSize = 128> struct SparseBitVectorElement {
BecameZero = false;
for (unsigned i = 0; i < BITWORDS_PER_ELEMENT; ++i) {
- BitWord old = changed ? 0 : Bits[i];
+ BitWord old = Bits[i];
Bits[i] &= RHS.Bits[i];
if (Bits[i] != 0)
allzero = false;
- if (!changed && old != Bits[i])
+ if (old != Bits[i])
changed = true;
}
BecameZero = allzero;
@@ -222,13 +222,13 @@ template <unsigned ElementSize = 128> struct SparseBitVectorElement {
BecameZero = false;
for (unsigned i = 0; i < BITWORDS_PER_ELEMENT; ++i) {
- BitWord old = changed ? 0 : Bits[i];
+ BitWord old = Bits[i];
Bits[i] &= ~RHS.Bits[i];
if (Bits[i] != 0)
allzero = false;
- if (!changed && old != Bits[i])
+ if (old != Bits[i])
changed = true;
}
BecameZero = allzero;
More information about the llvm-commits
mailing list