[llvm] [VPlan] Fix broadcasted values using loop region during execution (PR #142594)

[David Sherwood via llvm-commits]

================
@@ -290,18 +290,22 @@ Value *VPTransformState::get(const VPValue *Def, bool NeedsScalar) {
     return Data.VPV2Vector[Def];
 
   auto GetBroadcastInstrs = [this, Def](Value *V) {
+    VPBasicBlock *PreheaderVPBB = nullptr;
+    if (auto *Header = vputils::getFirstLoopHeader(*Plan, VPDT))
----------------
david-arm wrote:

Ah thanks for explaining! In that case, is it worth asserting `assert(!getVectorLoopRegion() && ...)` at the start of `GetBroadcastInstrs`?

https://github.com/llvm/llvm-project/pull/142594