[llvm] [ORC] Add Executor Resolver Utility (PR #143654)

via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 10 21:30:50 PDT 2025


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- llvm/include/llvm/ExecutionEngine/Orc/ExecutorResolutionGenerator.h llvm/include/llvm/ExecutionEngine/Orc/TargetProcess/ExecutorResolver.h llvm/lib/ExecutionEngine/Orc/ExecutorResolutionGenerator.cpp llvm/lib/ExecutionEngine/Orc/TargetProcess/ExecutorResolver.cpp llvm/include/llvm/ExecutionEngine/Orc/EPCGenericDylibManager.h llvm/include/llvm/ExecutionEngine/Orc/Shared/OrcRTBridge.h llvm/include/llvm/ExecutionEngine/Orc/Shared/TargetProcessControlTypes.h llvm/include/llvm/ExecutionEngine/Orc/TargetProcess/SimpleExecutorDylibManager.h llvm/lib/ExecutionEngine/Orc/EPCDebugObjectRegistrar.cpp llvm/lib/ExecutionEngine/Orc/EPCDynamicLibrarySearchGenerator.cpp llvm/lib/ExecutionEngine/Orc/EPCGenericDylibManager.cpp llvm/lib/ExecutionEngine/Orc/ExecutorProcessControl.cpp llvm/lib/ExecutionEngine/Orc/LookupAndRecordAddrs.cpp llvm/lib/ExecutionEngine/Orc/Shared/OrcRTBridge.cpp llvm/lib/ExecutionEngine/Orc/TargetProcess/SimpleExecutorDylibManager.cpp llvm/tools/lli/ForwardingMemoryManager.h llvm/unittests/ExecutionEngine/Orc/ObjectLinkingLayerTest.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/include/llvm/ExecutionEngine/Orc/EPCGenericDylibManager.h b/llvm/include/llvm/ExecutionEngine/Orc/EPCGenericDylibManager.h
index d64f7e7c0..440a3a375 100644
--- a/llvm/include/llvm/ExecutionEngine/Orc/EPCGenericDylibManager.h
+++ b/llvm/include/llvm/ExecutionEngine/Orc/EPCGenericDylibManager.h
@@ -52,8 +52,8 @@ public:
   LLVM_ABI Expected<tpctypes::DylibHandle> open(StringRef Path, uint64_t Mode);
 
   /// Looks up symbols within the given dylib.
-  Expected<tpctypes::LookupResult>
-  lookup(tpctypes::DylibHandle H, const SymbolLookupSet &Lookup) {
+  Expected<tpctypes::LookupResult> lookup(tpctypes::DylibHandle H,
+                                          const SymbolLookupSet &Lookup) {
     std::promise<MSVCPExpected<tpctypes::LookupResult>> RP;
     auto RF = RP.get_future();
     lookupAsync(H, Lookup, [&RP](auto R) { RP.set_value(std::move(R)); });
@@ -61,8 +61,8 @@ public:
   }
 
   /// Looks up symbols within the given dylib.
-  Expected<tpctypes::LookupResult>
-  lookup(tpctypes::DylibHandle H, const RemoteSymbolLookupSet &Lookup) {
+  Expected<tpctypes::LookupResult> lookup(tpctypes::DylibHandle H,
+                                          const RemoteSymbolLookupSet &Lookup) {
     std::promise<MSVCPExpected<tpctypes::LookupResult>> RP;
     auto RF = RP.get_future();
     lookupAsync(H, Lookup, [&RP](auto R) { RP.set_value(std::move(R)); });
diff --git a/llvm/lib/ExecutionEngine/Orc/EPCDynamicLibrarySearchGenerator.cpp b/llvm/lib/ExecutionEngine/Orc/EPCDynamicLibrarySearchGenerator.cpp
index 8177b5ed0..1e83c07f4 100644
--- a/llvm/lib/ExecutionEngine/Orc/EPCDynamicLibrarySearchGenerator.cpp
+++ b/llvm/lib/ExecutionEngine/Orc/EPCDynamicLibrarySearchGenerator.cpp
@@ -86,7 +86,8 @@ Error EPCDynamicLibrarySearchGenerator::tryToGenerate(
       const auto &Sym = *SymsIt++;
       if (Sym && Sym->getAddress())
         NewSymbols[Name] = *Sym;
-      else if (LLVM_UNLIKELY(!Sym && Flags == SymbolLookupFlags::RequiredSymbol))
+      else if (LLVM_UNLIKELY(!Sym &&
+                             Flags == SymbolLookupFlags::RequiredSymbol))
         MissingSymbols.insert(Name);
     }
 
diff --git a/llvm/lib/ExecutionEngine/Orc/ExecutorResolutionGenerator.cpp b/llvm/lib/ExecutionEngine/Orc/ExecutorResolutionGenerator.cpp
index 15cebb273..e5b0bd3db 100644
--- a/llvm/lib/ExecutionEngine/Orc/ExecutorResolutionGenerator.cpp
+++ b/llvm/lib/ExecutionEngine/Orc/ExecutorResolutionGenerator.cpp
@@ -71,7 +71,8 @@ Error ExecutorResolutionGenerator::tryToGenerate(
           const auto &Sym = *Syms++;
           if (Sym && Sym->getAddress())
             NewSyms[Name] = *Sym;
-          else if (LLVM_UNLIKELY(!Sym && Flags == SymbolLookupFlags::RequiredSymbol))
+          else if (LLVM_UNLIKELY(!Sym &&
+                                 Flags == SymbolLookupFlags::RequiredSymbol))
             MissingSymbols.insert(Name);
         }
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/143654


More information about the llvm-commits mailing list