[llvm] [X86][BreakFalseDeps] Using reverse order for undef register selection (PR #137569)
Evgenii Kudriashov via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 10 18:17:56 PDT 2025
================
@@ -142,7 +144,12 @@ void RegisterClassInfo::compute(const TargetRegisterClass *RC) const {
// FIXME: Once targets reserve registers instead of removing them from the
// allocation order, we can simply use begin/end here.
- ArrayRef<MCPhysReg> RawOrder = RC->getRawAllocationOrder(*MF);
+ ArrayRef<MCPhysReg> RawOrder = RC->getRawAllocationOrder(*MF, Reverse);
+ std::vector<MCPhysReg> ReverseOrder;
+ if (Reverse) {
+ llvm::append_range(ReverseOrder, reverse(RawOrder));
----------------
e-kud wrote:
I probably miss something but why can't we define the correct reverse order in `AltOrders` so we don't need to reverse a list once again. We've already passed `Reverse=true` to `getRawAllocationOrder` and after this need to reverse once more.
https://github.com/llvm/llvm-project/pull/137569
More information about the llvm-commits
mailing list