[llvm] [llvm-debuginfo-analyzer] Fix ODR violation in llvm::logicalview::LVObject (PR #140265)

[Saleem Abdulrasool via llvm-commits]

https://github.com/compnerd commented:

The changes for `dump` I think make sense. I'm not fully convinced about the remainder of the change. I think that we do want the ID checking in the debug builds (it is meant to be a debugging tool). If we are building without assertions, then we can enable it with ABI breaking changes. That is, I think that `#if !defined(NDEBUG) || ENABLE_ABI_BREAKING_CHANGES` is the right approach.

https://github.com/llvm/llvm-project/pull/140265