[llvm] [Support] Simplify CTLog2 (NFC) (PR #143559)
via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 10 08:54:27 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-support
Author: Kazu Hirata (kazutakahirata)
<details>
<summary>Changes</summary>
We can drop kValue > 0 in CTLog2 because llvm::isPowerOf2_64 returns
false on input 0.
---
Full diff: https://github.com/llvm/llvm-project/pull/143559.diff
1 Files Affected:
- (modified) llvm/include/llvm/Support/MathExtras.h (+1-2)
``````````diff
diff --git a/llvm/include/llvm/Support/MathExtras.h b/llvm/include/llvm/Support/MathExtras.h
index 246080aa45ce0..ae3150e5602ee 100644
--- a/llvm/include/llvm/Support/MathExtras.h
+++ b/llvm/include/llvm/Support/MathExtras.h
@@ -328,8 +328,7 @@ inline bool isShiftedMask_64(uint64_t Value, unsigned &MaskIdx,
/// Compile time Log2.
/// Valid only for positive powers of two.
template <size_t kValue> constexpr size_t CTLog2() {
- static_assert(kValue > 0 && llvm::isPowerOf2_64(kValue),
- "Value is not a valid power of 2");
+ static_assert(llvm::isPowerOf2_64(kValue), "Value is not a valid power of 2");
return 1 + CTLog2<kValue / 2>();
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/143559
More information about the llvm-commits
mailing list