[llvm] [memcpyopt] handle memcpy from memset in more cases (PR #140954)
Nikita Popov via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 10 08:22:09 PDT 2025
================
@@ -1418,19 +1437,26 @@ static bool hasUndefContents(MemorySSA *MSSA, BatchAAResults &AA, Value *V,
bool MemCpyOptPass::performMemCpyToMemSetOptzn(MemCpyInst *MemCpy,
MemSetInst *MemSet,
BatchAAResults &BAA) {
- // Make sure that memcpy(..., memset(...), ...), that is we are memsetting and
- // memcpying from the same address. Otherwise it is hard to reason about.
- if (!BAA.isMustAlias(MemSet->getRawDest(), MemCpy->getRawSource()))
- return false;
-
Value *MemSetSize = MemSet->getLength();
Value *CopySize = MemCpy->getLength();
- if (MemSetSize != CopySize) {
- // Make sure the memcpy doesn't read any more than what the memset wrote.
- // Don't worry about sizes larger than i64.
+ int64_t MOffset = 0;
+ const DataLayout &DL = MemCpy->getModule()->getDataLayout();
+ // We can only transforms memcpy's where the dest of one is the source of the
+ // other, or the memory transfer has a known offset from the memset.
+ if (MemCpy->getSource() != MemSet->getDest()) {
+ std::optional<int64_t> Offset =
+ MemCpy->getSource()->getPointerOffsetFrom(MemSet->getDest(), DL);
+ if (!Offset || *Offset < 0)
+ return false;
+ MOffset = *Offset;
+ }
- // A known memset size is required.
+ MaybeAlign MDestAlign = MemCpy->getDestAlign();
----------------
nikic wrote:
This variable appears to be unused?
https://github.com/llvm/llvm-project/pull/140954
More information about the llvm-commits
mailing list