[llvm] c3057de - [X86] Fix bugprone-argument-comment warnings. NFC.
Simon Pilgrim via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 10 06:25:52 PDT 2025
Author: Simon Pilgrim
Date: 2025-06-10T14:25:29+01:00
New Revision: c3057de024b70be6c1bc95a2aba49eb288d69a91
URL: https://github.com/llvm/llvm-project/commit/c3057de024b70be6c1bc95a2aba49eb288d69a91
DIFF: https://github.com/llvm/llvm-project/commit/c3057de024b70be6c1bc95a2aba49eb288d69a91.diff
LOG: [X86] Fix bugprone-argument-comment warnings. NFC.
Added:
Modified:
llvm/lib/Target/X86/X86ISelLowering.cpp
Removed:
################################################################################
diff --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp
index bf5ba25cd3104..09a8276f59708 100644
--- a/llvm/lib/Target/X86/X86ISelLowering.cpp
+++ b/llvm/lib/Target/X86/X86ISelLowering.cpp
@@ -41586,8 +41586,8 @@ static SDValue combineX86ShufflesRecursively(SDValue Op, SelectionDAG &DAG,
const X86Subtarget &Subtarget) {
return combineX86ShufflesRecursively(
{Op}, 0, Op.getOpcode(), Op.getSimpleValueType(), {0}, {}, /*Depth=*/0,
- X86::MaxShuffleCombineDepth, /*AllowCrossLaneVarMask=*/true,
- /*AllowPerLaneVarMask=*/true, isMaskableNode(Op, Subtarget), DAG,
+ X86::MaxShuffleCombineDepth, /*AllowVariableCrossLaneMask=*/true,
+ /*AllowVariablePerLaneMask=*/true, isMaskableNode(Op, Subtarget), DAG,
SDLoc(Op), Subtarget);
}
@@ -42241,7 +42241,8 @@ static SDValue combineTargetShuffle(SDValue N, const SDLoc &DL,
if (SDValue Res = combineX86ShufflesRecursively(
{BC}, 0, BC.getOpcode(), BC.getSimpleValueType(), DemandedMask,
{}, /*Depth=*/0, X86::MaxShuffleCombineDepth,
- /*AllowCrossLaneVarMask=*/true, /*AllowPerLaneVarMask=*/true,
+ /*AllowVariableCrossLaneMask=*/true,
+ /*AllowVariablePerLaneMask=*/true,
/*IsMaskedShuffle=*/false, DAG, DL, Subtarget))
return DAG.getNode(X86ISD::VBROADCAST, DL, VT,
DAG.getBitcast(SrcVT, Res));
@@ -44388,9 +44389,10 @@ bool X86TargetLowering::SimplifyDemandedVectorEltsForTargetNode(
SDValue NewShuffle = combineX86ShufflesRecursively(
{Op}, 0, Op.getOpcode(), Op.getSimpleValueType(), DemandedMask, {}, 0,
- X86::MaxShuffleCombineDepth - Depth, /*AllowCrossLaneVarMask=*/true,
- /*AllowPerLaneVarMask=*/true, isMaskableNode(Op, Subtarget), TLO.DAG,
- SDLoc(Op), Subtarget);
+ X86::MaxShuffleCombineDepth - Depth,
+ /*AllowVariableCrossLaneMask=*/true,
+ /*AllowVariablePerLaneMask=*/true, isMaskableNode(Op, Subtarget),
+ TLO.DAG, SDLoc(Op), Subtarget);
if (NewShuffle)
return TLO.CombineTo(Op, NewShuffle);
}
@@ -52056,7 +52058,8 @@ static SDValue combineAnd(SDNode *N, SelectionDAG &DAG,
if (SDValue Shuffle = combineX86ShufflesRecursively(
{SrcVec}, 0, SrcVec.getOpcode(), SrcVec.getSimpleValueType(),
ShuffleMask, {}, /*Depth=*/1, X86::MaxShuffleCombineDepth,
- /*AllowVarCrossLaneMask=*/true, /*AllowVarPerLaneMask=*/true,
+ /*AllowVariableCrossLaneMask=*/true,
+ /*AllowVariablePerLaneMask=*/true,
/*IsMaskedShuffle=*/false, DAG, SDLoc(SrcVec), Subtarget))
return DAG.getNode(ISD::EXTRACT_VECTOR_ELT, dl, VT, Shuffle,
N0.getOperand(1));
More information about the llvm-commits
mailing list