[llvm] [llvm] annotate interfaces in llvm-c for DLL export (PR #141701)

Andrew Rogers via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 9 15:41:00 PDT 2025


================
@@ -334,7 +334,7 @@ LLVM_C_ABI extern void LLVMRemarkParserDispose(LLVMRemarkParserRef Parser);
  *
  * \since REMARKS_API_VERSION=0
  */
-LLVM_C_ABI extern uint32_t LLVMRemarkVersion(void);
+extern uint32_t LLVMRemarkVersion(void);
----------------
andrurogerz wrote:

This one is weird. `LLVMRemarkVersion` is implemented in a different library [here](https://github.com/llvm/llvm-project/blob/main/llvm/tools/remarks-shlib/libremarks.cpp#L15). I don't know what the correct solution is here, but the implementation is not linked into llvm so can't be exported by llvm. It feels like either the header doesn't belong here or the implementation should be moved so it does link into llvm.

https://github.com/llvm/llvm-project/pull/141701


More information about the llvm-commits mailing list