[llvm] [AMDGPU] Fix getAsmVOP3Base SrcMods arguments. NFCI. (PR #143428)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 9 12:51:23 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-backend-amdgpu
Author: Stanislav Mekhanoshin (rampitec)
<details>
<summary>Changes</summary>
Somehow we ended up with different code here and downstream
after merges, and beeing specific about SrcMods is more
correct.
---
Full diff: https://github.com/llvm/llvm-project/pull/143428.diff
1 Files Affected:
- (modified) llvm/lib/Target/AMDGPU/SIInstrInfo.td (+2-2)
``````````diff
diff --git a/llvm/lib/Target/AMDGPU/SIInstrInfo.td b/llvm/lib/Target/AMDGPU/SIInstrInfo.td
index 083345d4d1e12..9c1d82b50c1a5 100644
--- a/llvm/lib/Target/AMDGPU/SIInstrInfo.td
+++ b/llvm/lib/Target/AMDGPU/SIInstrInfo.td
@@ -2671,8 +2671,8 @@ class VOPProfile <list<ValueType> _ArgVT, bit _EnableClamp = 0> {
// the asm operand name via this HasModifiers flag
field string AsmDPP8 = getAsmDPP8<HasDst, NumSrcArgs, 0 /*HasModifiers*/, DstVT>.ret;
field string AsmVOP3Base = getAsmVOP3Base<NumSrcArgs, HasDst, HasClamp,
- HasOpSel, HasOMod, IsVOP3P, HasNeg, HasModifiers, HasModifiers,
- HasModifiers, DstVT, HasFP8ByteSel>.ret;
+ HasOpSel, HasOMod, IsVOP3P, HasNeg, HasSrc0Mods, HasSrc1Mods,
+ HasSrc2Mods, DstVT, HasFP8ByteSel>.ret;
field string Asm64 = AsmVOP3Base;
field string AsmVOP3P = getAsmVOP3P<HasDst, NumSrcArgs, HasNeg, HasClamp, HasOpSel>.ret;
field string AsmVOP3OpSel = getAsmVOP3OpSel<NumSrcArgs,
``````````
</details>
https://github.com/llvm/llvm-project/pull/143428
More information about the llvm-commits
mailing list