[llvm] [AMDGPU] Fix getAsmVOP3Base SrcMods arguments. NFCI. (PR #143428)

Stanislav Mekhanoshin via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 9 12:48:58 PDT 2025


https://github.com/rampitec created https://github.com/llvm/llvm-project/pull/143428

Somehow we ended up with different code here and downstream
after merges, and beeing specific about SrcMods is more
correct.

>From 7da91b531d76ed2b00781b217e6c239f66a98296 Mon Sep 17 00:00:00 2001
From: Stanislav Mekhanoshin <Stanislav.Mekhanoshin at amd.com>
Date: Mon, 9 Jun 2025 12:38:06 -0700
Subject: [PATCH] [AMDGPU] Fix getAsmVOP3Base SrcMods arguments. NFCI.

Somehow we ended up with different code here and downstream
after merges, and beeing specific about SrcMods is more
correct.
---
 llvm/lib/Target/AMDGPU/SIInstrInfo.td | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/llvm/lib/Target/AMDGPU/SIInstrInfo.td b/llvm/lib/Target/AMDGPU/SIInstrInfo.td
index 083345d4d1e12..9c1d82b50c1a5 100644
--- a/llvm/lib/Target/AMDGPU/SIInstrInfo.td
+++ b/llvm/lib/Target/AMDGPU/SIInstrInfo.td
@@ -2671,8 +2671,8 @@ class VOPProfile <list<ValueType> _ArgVT, bit _EnableClamp = 0> {
   // the asm operand name via this HasModifiers flag
   field string AsmDPP8 = getAsmDPP8<HasDst, NumSrcArgs, 0 /*HasModifiers*/, DstVT>.ret;
   field string AsmVOP3Base = getAsmVOP3Base<NumSrcArgs, HasDst, HasClamp,
-   HasOpSel, HasOMod, IsVOP3P, HasNeg, HasModifiers, HasModifiers,
-   HasModifiers, DstVT, HasFP8ByteSel>.ret;
+   HasOpSel, HasOMod, IsVOP3P, HasNeg, HasSrc0Mods, HasSrc1Mods,
+   HasSrc2Mods, DstVT, HasFP8ByteSel>.ret;
   field string Asm64 = AsmVOP3Base;
   field string AsmVOP3P = getAsmVOP3P<HasDst, NumSrcArgs, HasNeg, HasClamp, HasOpSel>.ret;
   field string AsmVOP3OpSel = getAsmVOP3OpSel<NumSrcArgs,



More information about the llvm-commits mailing list