[llvm] [GlobalOpt] Bail out for ConstantPtrAuth in isSimpleEnoughtToCommit. (PR #143400)

[Oliver Hunt via llvm-commits]

================
@@ -74,6 +74,9 @@ isSimpleEnoughValueToCommitHelper(Constant *C,
     return true;
   }
 
+  if (isa<ConstantPtrAuth>(C))
----------------
ojhunt wrote:

Obviously the early return works, but dyn_cast certainly seems like the robust solution - there doesn't seem to be any obvious indication that C is required to be a specific set of subclasses of Constant.

I don't know the impact of return false vs true - I don't know backend concepts so I don't know what it means to commit a helper here?

https://github.com/llvm/llvm-project/pull/143400