[llvm] [GlobalOpt] Bail out for ConstantPtrAuth in isSimpleEnoughtToCommit. (PR #143400)

[via llvm-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-llvm-transforms

Author: Florian Hahn (fhahn)

<details>
<summary>Changes</summary>

Bail out for ConstantPtrAuth constants in isSimpleEnoughValueToCommitHelper to prevent crash in cast<ConstantExpr> below.

---
Full diff: https://github.com/llvm/llvm-project/pull/143400.diff


2 Files Affected:

- (modified) llvm/lib/Transforms/Utils/Evaluator.cpp (+3) 
- (added) llvm/test/Transforms/GlobalOpt/global-constructor-ptrauth-constant.ll (+27) 


``````````diff
diff --git a/llvm/lib/Transforms/Utils/Evaluator.cpp b/llvm/lib/Transforms/Utils/Evaluator.cpp
index 2af447aadce22..ecdcdf55d5089 100644
--- a/llvm/lib/Transforms/Utils/Evaluator.cpp
+++ b/llvm/lib/Transforms/Utils/Evaluator.cpp
@@ -74,6 +74,9 @@ isSimpleEnoughValueToCommitHelper(Constant *C,
     return true;
   }
 
+  if (isa<ConstantPtrAuth>(C))
+    return false;
+
   // We don't know exactly what relocations are allowed in constant expressions,
   // so we allow &global+constantoffset, which is safe and uniformly supported
   // across targets.
diff --git a/llvm/test/Transforms/GlobalOpt/global-constructor-ptrauth-constant.ll b/llvm/test/Transforms/GlobalOpt/global-constructor-ptrauth-constant.ll
new file mode 100644
index 0000000000000..ef64b3eb1147c
--- /dev/null
+++ b/llvm/test/Transforms/GlobalOpt/global-constructor-ptrauth-constant.ll
@@ -0,0 +1,27 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --check-globals all --version 5
+; RUN: opt -p globalopt -S %s | FileCheck %s
+
+ at llvm.global_ctors = appending global [1 x { i32, ptr, ptr }] [{ i32, ptr, ptr } { i32 65535, ptr @ctor, ptr null }]
+
+ at foo = internal global ptr null
+
+declare void @user(ptr)
+
+;.
+; CHECK: @llvm.global_ctors = appending global [1 x { i32, ptr, ptr }] [{ i32, ptr, ptr } { i32 65535, ptr @ctor, ptr null }]
+; CHECK: @foo = internal global ptr null
+;.
+define void @ctor() {
+; CHECK-LABEL: define void @ctor() {
+; CHECK-NEXT:  [[ENTRY:.*:]]
+; CHECK-NEXT:    [[DST:%.*]] = alloca ptr, align 8
+; CHECK-NEXT:    store ptr ptrauth (ptr @foo, i32 0), ptr [[DST]], align 8
+; CHECK-NEXT:    call void @user(ptr [[DST]])
+; CHECK-NEXT:    ret void
+;
+entry:
+  %dst = alloca ptr, align 8
+  store ptr ptrauth (ptr @foo, i32 0), ptr %dst, align 8
+  call void @user(ptr %dst)
+  ret void
+}

``````````

</details>


https://github.com/llvm/llvm-project/pull/143400