[llvm] Add --offoading option to llvm-readobj (PR #143342)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 9 01:43:09 PDT 2025


================
@@ -230,4 +232,21 @@ void ObjDumper::printSectionsAsHex(const object::ObjectFile &Obj,
   }
 }
 
+// TODO: add proper error handling.
+void ObjDumper::printOffloading(const object::ObjectFile &Obj) {
+  // we can use an argument to let user select which offloading section they
+  // want to print. but for now, we're hardcoding ELF and "hip_fatbin".
----------------
jh7370 wrote:

Please use proper English grammar for comments, including leading capital letters and a comma before "but" not a full stop.

Should this be a TODO?

https://github.com/llvm/llvm-project/pull/143342


More information about the llvm-commits mailing list