[llvm] Add --offoading option to llvm-readobj (PR #143342)

[James Henderson via llvm-commits]

================
@@ -230,4 +232,21 @@ void ObjDumper::printSectionsAsHex(const object::ObjectFile &Obj,
   }
 }
 
+// TODO: add proper error handling.
+void ObjDumper::printOffloading(const object::ObjectFile &Obj) {
+  // we can use an argument to let user select which offloading section they
+  // want to print. but for now, we're hardcoding ELF and "hip_fatbin".
+  assert((Obj.isELF() || Obj.isCOFF()) && "Invalid file type");
+
+  SmallVector<llvm::object::OffloadBundleFatBin> Bundles;
+  if (Error Err = llvm::object::extractOffloadBundleFatBinary(Obj, Bundles))
+    reportWarning(createError("Cannot extract Fatbin Binary from Object."),
----------------
jh7370 wrote:

Also:
* No trailing full stop.
* Why are "Fatbin", "Binary" and "Object" capitalised?
* Is there any more context you could include in this warning? For example, what does `Err` include?
* Can we add a test case for this warning, please?

Coding standards citation: https://llvm.org/docs/CodingStandards.html#error-and-warning-messages

https://github.com/llvm/llvm-project/pull/143342